Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kserve: Update the Models web app #2158

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/kserve/models-web-app/base/istio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: kserve
spec:
gateways:
- $(ingressGateway)
- knative-serving/knative-ingress-gateway
hosts:
- '*'
http:
Expand Down
1 change: 1 addition & 0 deletions contrib/kserve/models-web-app/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ images:
newTag: v0.7.0
configMapGenerator:
- name: kserve-models-web-app-config
namespace: kserve
literals:
- APP_DISABLE_AUTH="True"
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ generatorOptions:
# kserve namespace in webhook configurations
configMapGenerator:
- name: kserve-models-web-app-config
namespace: kserve
behavior: replace
literals:
- USERID_HEADER=kubeflow-userid
- APP_PREFIX=/kserve-endpoints

configurations:
- params.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
- op: replace
path: /spec/gateways
value:
- kubeflow/kubeflow-gateway
- op: replace
path: /spec/http/0/route/0/destination
value:
Expand Down