Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kserve: Update the Models web app #2158

Merged

Conversation

kimwnasptd
Copy link
Member

Update the app's manifests to:

  1. Work under the /kserve-endpoints prefix manifests: Update gateways and prefix kserve/models-web-app#32
  2. Use the correct gatway in the manifests manifests: Update gateways and prefix kserve/models-web-app#32
  3. Use the correct namespace in for the app's ConfigMap Specify namespace for kserve web app configmap kserve/models-web-app#33

cc @kubeflow/release-team

Update the app's manifests to:
1. Work under the /kserve-endpoints prefix
2. Use the correct gatway in the manifests
3. Use the correct namespace in for the app's ConfigMap

Signed-off-by: Kimonas Sotirchos <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elikatsis
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 4, 2022
@google-oss-prow google-oss-prow bot merged commit 3b93df7 into kubeflow:master Mar 4, 2022
@elikatsis elikatsis deleted the feature-kimwnasptd-kserve-mwa branch March 4, 2022 17:55
kimwnasptd added a commit that referenced this pull request Mar 4, 2022
Update the app's manifests to:
1. Work under the /kserve-endpoints prefix
2. Use the correct gatway in the manifests
3. Use the correct namespace in for the app's ConfigMap

Signed-off-by: Kimonas Sotirchos <[email protected]>
@kimwnasptd kimwnasptd mentioned this pull request Mar 4, 2022
kevin85421 pushed a commit to juliusvonkohout/manifests that referenced this pull request Feb 28, 2023
Update the app's manifests to:
1. Work under the /kserve-endpoints prefix
2. Use the correct gatway in the manifests
3. Use the correct namespace in for the app's ConfigMap

Signed-off-by: Kimonas Sotirchos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants