Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies ahead of aws-ebs-csi-driver v1.26.0 #1867

Merged

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Dec 13, 2023

Is this a bug fix or adding new feature?
Dependency upgrades

What is this PR about? / Why do we need it?
Upgrade dependencies ahead of aws-ebs-csi-driver v1.26.0

Note: This PR currently stacks on top of 1858, will rebase (and squash) once that is merged. Therefore, ignore the driver.go change.

See commits for each change:

  • Driver dependency upgrades
  • CI job dependency upgrades
  • Sidecar image upagrades
  • Mock updates
  • Fixing govet error after dependency upgrades: tests/e2e/testsuites/testsuites.go:426:15: cannot use v1.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal
  • Add U7i attachment limits (Instance type currently in preview)

Note: Closes #1849

What testing is done?
make test & make verify

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

Code Coverage Diff

This PR does not change the code coverage

@ConnorJC3
Copy link
Contributor

/label tide/merge-method-squash

/lgtm

Will need to be rebased, so hold off on approving

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@torredil
Copy link
Member

/retest

@AndrewSirenko
Copy link
Contributor Author

/hold

Due to needing to rebase post 1858

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@AndrewSirenko
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@AndrewSirenko
Copy link
Contributor Author

/retest

Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
Upgrade Prow CI job dependencies for aws-ebs-csi-driver v1.26.0

Upgrade sidecar images for aws-ebs-csi-driver v1.26.0

Update mocks for aws-ebs-csi-driver v1.26.0

Fix govet error due to dependency upgrades in e2e tests.

Add U7i attachment limits
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 09f742f into kubernetes-sigs:master Dec 14, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump aws go sdk to > v1.47.11
4 participants