-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies ahead of aws-ebs-csi-driver v1.26.0 #1867
Upgrade dependencies ahead of aws-ebs-csi-driver v1.26.0 #1867
Conversation
Code Coverage DiffThis PR does not change the code coverage |
/label tide/merge-method-squash /lgtm Will need to be rebased, so hold off on approving |
/retest |
/hold Due to needing to rebase post 1858 |
866ef60
to
182c790
Compare
/unhold |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
/lgtm
Upgrade Prow CI job dependencies for aws-ebs-csi-driver v1.26.0 Upgrade sidecar images for aws-ebs-csi-driver v1.26.0 Update mocks for aws-ebs-csi-driver v1.26.0 Fix govet error due to dependency upgrades in e2e tests. Add U7i attachment limits
182c790
to
1c57951
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Dependency upgrades
What is this PR about? / Why do we need it?
Upgrade dependencies ahead of aws-ebs-csi-driver v1.26.0
Note: This PR currently stacks on top of 1858, will rebase (and squash) once that is merged. Therefore, ignore the driver.go change.See commits for each change:
tests/e2e/testsuites/testsuites.go:426:15: cannot use v1.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal
Note: Closes #1849
What testing is done?
make test
&make verify