Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeComponentOnly parameter to helm chart #2106

Merged

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Aug 9, 2024

Is this a bug fix or adding new feature?

/feature

What is this PR about? / Why do we need it?

Add a nodeComponentOnly parameter to helm chart.

What testing is done?

Here are helm template results with and without setting nodeComponentOnly=true, as well as the diff (as textfiles because gists don't support yaml):

nodeComponentOnlyTemplate.txt
defaultChart.txt
diff.txt

Also deployed the driver with this setting:

helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  $HOME/workplace/aws-ebs-csi-driver/charts/aws-ebs-csi-driver \
  --values "$HOME/workplace/tools/driver-testing/driver-up/custom_values.yaml" \
  --set nodeComponentOnly=true

Release "aws-ebs-csi-driver" does not exist. Installing it now.
NAME: aws-ebs-csi-driver
LAST DEPLOYED: Fri Aug  9 18:51:28 2024
NAMESPACE: kube-system
STATUS: deployed
REVISION: 1
...

❯ kubectl get pod -n kube-system -l "app.kubernetes.io/name=aws-ebs-csi-driver,app.kubernetes.io/instance=aws-ebs-csi-driver"
NAME                 READY   STATUS    RESTARTS   AGE
ebs-csi-node-4cxvv   3/3     Running   0          12s
ebs-csi-node-57f2r   3/3     Running   0          12s
ebs-csi-node-kss7k   3/3     Running   0          12s
ebs-csi-node-tq9sv   3/3     Running   0          12s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

Code Coverage Diff

This PR does not change the code coverage

@AndrewSirenko AndrewSirenko marked this pull request as draft August 9, 2024 19:14
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
@AndrewSirenko AndrewSirenko marked this pull request as ready for review August 9, 2024 20:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from torredil Aug 11, 2024
@AndrewSirenko
Copy link
Contributor Author

AndrewSirenko commented Aug 11, 2024

/hold

For better name. Leaning towards nodeDriverOnly

Edit: Connor proposed nodeComponentOnly, I'm a fan.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2024
@AndrewSirenko AndrewSirenko force-pushed the disableControllerHelm branch from cb4ddbc to 86b7f61 Compare August 13, 2024 13:15
@AndrewSirenko AndrewSirenko changed the title Add disableController parameter to helm chart Add nodeComponentOnly parameter to helm chart Aug 13, 2024
@AndrewSirenko
Copy link
Contributor Author

/unhold

Name found

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@AndrewSirenko AndrewSirenko marked this pull request as draft August 13, 2024 13:18
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@AndrewSirenko AndrewSirenko marked this pull request as ready for review August 13, 2024 13:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely lgtm, two comments

@ConnorJC3
Copy link
Contributor

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit bac3457 into kubernetes-sigs:master Aug 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants