-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodeComponentOnly parameter to helm chart #2106
Add nodeComponentOnly parameter to helm chart #2106
Conversation
Code Coverage DiffThis PR does not change the code coverage |
/hold For better name. Leaning towards Edit: Connor proposed |
cb4ddbc
to
86b7f61
Compare
/unhold Name found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely lgtm, two comments
charts/aws-ebs-csi-driver/templates/serviceaccount-csi-controller.yaml
Outdated
Show resolved
Hide resolved
86b7f61
to
3565ca0
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
/feature
What is this PR about? / Why do we need it?
Add a nodeComponentOnly parameter to helm chart.
What testing is done?
Here are helm template results with and without setting nodeComponentOnly=true, as well as the diff (as textfiles because gists don't support yaml):
nodeComponentOnlyTemplate.txt
defaultChart.txt
diff.txt
Also deployed the driver with this setting: