Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DNS workaround for ipv6 templates #4350

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Remove DNS workaround for ipv6 templates #4350

merged 1 commit into from
Dec 12, 2023

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Dec 9, 2023 •
edited
Loading

What type of PR is this?

What this PR does / why we need it: See #4210

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4210

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 9, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 9, 2023
@CecileRobertMichon CecileRobertMichon mentioned this pull request Dec 9, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d7e883) 60.89% compared to head (adf2190) 60.89%.
Report is 14 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4350   +/-   ##
=======================================
  Coverage   60.89%   60.89%           
=======================================
  Files         190      190           
  Lines       18983    18983           
=======================================
  Hits        11559    11559           
  Misses       6787     6787           
  Partials      637      637

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CecileRobertMichon
Copy link
Contributor Author

[FAILED] Failed to generate the manifest for "addon-helm" / "v0.1.0-alpha.10"

/retest

unrelated prow network flake

@CecileRobertMichon
Copy link
Contributor Author

/retest

security rules flake

@mboersma
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-optional

@CecileRobertMichon
Copy link
Contributor Author

/retest

Unfortunate that the dual stack test failed on this one, but it does look like an unrelated Azure error (InternalExecutionError) creating the load balancer

mboersma
mboersma reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @nojnhuh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f4e2dff132cfc6f2e7c6be0a6bd3171929687cec

nojnhuh
nojnhuh reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0ccc4d3 into kubernetes-sigs:main Dec 12, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Dec 12, 2023
lzhecheng added a commit to lzhecheng/cloud-provider-azure that referenced this pull request Feb 5, 2024
@lzhecheng
Update IPv6 template
3d47733 
Remove DNS workaround
Followed: kubernetes-sigs/cluster-api-provider-azure#4350

Signed-off-by: Zhecheng Li <[email protected]>
This was referenced Feb 5, 2024
Merged
Closed
comtalyst pushed a commit to comtalyst/cloud-provider-azure that referenced this pull request Mar 4, 2024
@lzhecheng @comtalyst
Update IPv6 template
31885d4 
Remove DNS workaround
Followed: kubernetes-sigs/cluster-api-provider-azure#4350

Signed-off-by: Zhecheng Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@mboersma mboersma mboersma left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Remove DNS workaround for ipv6 templates
4 participants
@CecileRobertMichon @mboersma @k8s-ci-robot @nojnhuh