-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: consolidationWarnings use goroutine #1650
base: main
Are you sure you want to change the base?
chore: consolidationWarnings use goroutine #1650
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: helen-frank The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 11357494077Details
💛 - Coveralls |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
a6c8873
to
7a454ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here. Why do we need this? What's the performance benefit?
The two for loops do not interfere with each other's logic, and I think that simple asynchronous processing can make it faster, more so when there are more pods. |
7a454ee
to
e72d529
Compare
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Description
Asynchronously accelerating the execution of
consolidationWarnings
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.