Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consolidationWarnings use goroutine #1650

Closed
wants to merge 1 commit into from
Closed

chore: consolidationWarnings use goroutine #1650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 41 additions & 21 deletions pkg/controllers/provisioning/provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"errors"
"fmt"
"strings"
"sync"
"time"

"github.com/awslabs/operatorpkg/option"
Expand Down Expand Up @@ -176,33 +177,52 @@ func (p *Provisioner) GetPendingPods(ctx context.Context) ([]*corev1.Pod, error)
func (p *Provisioner) consolidationWarnings(ctx context.Context, pods []*corev1.Pod) {
// We have pending pods that have preferred anti-affinity or topology spread constraints. These can interact
// unexpectedly with consolidation, so we warn once per hour when we see these pods.
antiAffinityPods := lo.FilterMap(pods, func(po *corev1.Pod, _ int) (client.ObjectKey, bool) {
if po.Spec.Affinity != nil && po.Spec.Affinity.PodAntiAffinity != nil {
if len(po.Spec.Affinity.PodAntiAffinity.PreferredDuringSchedulingIgnoredDuringExecution) != 0 {
if p.cm.HasChanged(string(po.UID), "pod-antiaffinity") {
return client.ObjectKeyFromObject(po), true

wg := sync.WaitGroup{}

wg.Add(2)

go func() {
antiAffinityPods := lo.FilterMap(pods, func(po *corev1.Pod, _ int) (client.ObjectKey, bool) {
if po.Spec.Affinity != nil && po.Spec.Affinity.PodAntiAffinity != nil {
if len(po.Spec.Affinity.PodAntiAffinity.PreferredDuringSchedulingIgnoredDuringExecution) != 0 {
if p.cm.HasChanged(string(po.UID), "pod-antiaffinity") {
return client.ObjectKeyFromObject(po), true
}
}
}
return client.ObjectKey{}, false
})

// We reduce the amount of logging that we do per-pod by grouping log lines like this together
if len(antiAffinityPods) > 0 {
log.FromContext(ctx).WithValues("pods", pretty.Slice(antiAffinityPods, 10)).Info("pod(s) have a preferred Anti-Affinity which can prevent consolidation")
}
return client.ObjectKey{}, false
})
topologySpreadPods := lo.FilterMap(pods, func(po *corev1.Pod, _ int) (client.ObjectKey, bool) {
for _, tsc := range po.Spec.TopologySpreadConstraints {
if tsc.WhenUnsatisfiable == corev1.ScheduleAnyway {
if p.cm.HasChanged(string(po.UID), "pod-topology-spread") {
return client.ObjectKeyFromObject(po), true

wg.Done()
}()

go func() {
topologySpreadPods := lo.FilterMap(pods, func(po *corev1.Pod, _ int) (client.ObjectKey, bool) {
for _, tsc := range po.Spec.TopologySpreadConstraints {
if tsc.WhenUnsatisfiable == corev1.ScheduleAnyway {
if p.cm.HasChanged(string(po.UID), "pod-topology-spread") {
return client.ObjectKeyFromObject(po), true
}
}
}
return client.ObjectKey{}, false
})

// We reduce the amount of logging that we do per-pod by grouping log lines like this together
if len(topologySpreadPods) > 0 {
log.FromContext(ctx).WithValues("pods", pretty.Slice(topologySpreadPods, 10)).Info("pod(s) have a preferred TopologySpreadConstraint which can prevent consolidation")
}
return client.ObjectKey{}, false
})
// We reduce the amount of logging that we do per-pod by grouping log lines like this together
if len(antiAffinityPods) > 0 {
log.FromContext(ctx).WithValues("pods", pretty.Slice(antiAffinityPods, 10)).Info("pod(s) have a preferred Anti-Affinity which can prevent consolidation")
}
if len(topologySpreadPods) > 0 {
log.FromContext(ctx).WithValues("pods", pretty.Slice(topologySpreadPods, 10)).Info("pod(s) have a preferred TopologySpreadConstraint which can prevent consolidation")
}

wg.Done()
}()

wg.Wait()
}

var ErrNodePoolsNotFound = errors.New("no nodepools found")
Expand Down
Loading