Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release new version v0.0.19 of retina #4244

Closed
wants to merge 1 commit into from
Closed

release new version v0.0.19 of retina #4244

wants to merge 1 commit into from

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v0.0.19 of retina on behalf of @SRodi.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Nov 27, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/retina.yaml is not a straightforward version bump: version should move forward ("v0.10.1" vs "v0.0.19")
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krew-release-bot
Once this PR has been reviewed and has the lgtm label, please assign ahmetb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2024
@SRodi
Copy link
Member

SRodi commented Nov 28, 2024 •
edited
Loading

@ahmetb @chriskim06 Please approve this PR. v0.10.1 does not exist and retina is currently broken on krew-index. We published v0.10.1 so that we could retract v0.10.0, which was mistakenly published. See this comment microsoft/retina#1020 (comment)

@SRodi SRodi mentioned this pull request Dec 3, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SRodi
Copy link
Member

SRodi commented Dec 4, 2024

@chriskim06 this PR can be closed since v0.0.20 was merged yesterday #4258

@ahmetb ahmetb closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krew-release-bot @ahmetb @k8s-ci-robot @SRodi