Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v0.0.20 of retina #4258

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v0.0.20 of retina on behalf of @SRodi.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Dec 3, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/retina.yaml is not a straightforward version bump: version should move forward ("v0.10.1" vs "v0.0.20")
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2024
@SRodi
Copy link
Member

SRodi commented Dec 3, 2024

@ahmetb @chriskim06 @corneliusweig can someone please review/approve this? krew install retina is currently broken. Also, our previous release v0.0.19 was never merged, and now we are pushing v0.0.20 to fix a critical issue on v0.0.19. We want to have v0.0.20 on krew-index.

See this comment #4244 (comment)

# this is broken as v0.10.1 does not exist (see comment above)
❯ kubectl krew install retina
Updated the local copy of plugin index.
Installing plugin: retina
W1203 10:02:45.088690 1577772 install.go:164] failed to install plugin "retina": install failed: failed to unpack into staging dir: failed to unpack the plugin archive: failed to obtain plugin archive: failed to download "https://github.com/microsoft/retina/releases/download/v0.10.1/kubectl-retina-linux-amd64-v0.10.1.tar.gz", status code 404
failed to install some plugins: [retina]: install failed: failed to unpack into staging dir: failed to unpack the plugin archive: failed to obtain plugin archive: failed to download "https://github.com/microsoft/retina/releases/download/v0.10.1/kubectl-retina-linux-amd64-v0.10.1.tar.gz", status code 404

Thanks for your help!

@chriskim06
Copy link
Member

sorry about this, i missed your previous comment
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chriskim06, krew-release-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit cb09f2e into kubernetes-sigs:master Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants