CA: optimized pod list and classification #8744
Open
+37
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
area/cluster-autoscaler
size/M
Contributor
Author
x13n
reviewed
Nov 4, 2025
jackfrancis
force-pushed
the
listPods-simplified
branch
from
3245e34 to
0395f8f
Compare
x13n
reviewed
Nov 5, 2025
Member
x13n
left a comment
x13n
left a comment
There was a problem hiding this comment.
/lgtm
/hold for one more readability comment, feel free to cancel if you disagree
k8s-ci-robot
added
do-not-merge/hold
jackfrancis
force-pushed
the
listPods-simplified
branch
from
0395f8f to
6684df5
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR simplifies the ways we classify scheduled, unschedulable, and unprocessed pods so that we filter only once per static RunOnce loop.
In particular we avoid checking for "is pod scheduled?", "is pod deleted", and "is pod unschedulable?" twice or three times in rapid succession during the
listPodshelper func in theRunOnceloop.tl;dr the
ScheduledPods,UnschedulablePods, andSchedulerUnprocessedPodsfuncs are collapsed into a singleFilterPodsBySchedulabilityfunc, where their related outcomes can be handled in a single place, avoiding the repeated evaluations that the current cascading sequence produces.There are no changes to UT by design, to prove that this doesn't change any outcomes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: