Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issues for tab panes #48847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Farice4
Copy link
Contributor

@Farice4 Farice4 commented Nov 26, 2024

Description

Issue

content/en/docs/tasks/tools/install-kubectl-linux.md

Closes: #48813

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2024
@Farice4
Copy link
Contributor Author

Farice4 commented Nov 26, 2024

/assign @chalin

@k8s-ci-robot
Copy link
Contributor

@Farice4: GitHub didn't allow me to assign the following users: chalin.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @chalin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Nov 26, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6aea36f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6745af27a24e4e00090307e3
😎 Deploy Preview https://deploy-preview-48847--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Nov 26, 2024

/retitle Fix formatting issues for tab panes

@k8s-ci-robot k8s-ci-robot changed the title [en] Fix Tab panes have formatting issues (#48813) Fix formatting issues for tab panes Nov 26, 2024
@@ -38,6 +38,7 @@ The following methods exist for installing kubectl on Linux:
{{< note >}}
To download a specific version, replace the `$(curl -L -s https://dl.k8s.io/release/stable.txt)`
portion of the command with the specific version.
{{< /note >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but this change to move the note shortcode doesn’t look correct. It seems the current changes in the PR does not align with the reported issue’s requirements. The issue #48813 reports that the tab content not include a full bounding box. For clarity, you can refer to the link of the same page for older version of docs (here) to see the expected appearance.

Hope these links help with understanding the required change!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For added clarity, here’s a screenshot from the issue that shows the problem.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab panes have formatting issues
5 participants