-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting issues for tab panes #48847
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yuanbin Chen <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @chalin |
@Farice4: GitHub didn't allow me to assign the following users: chalin. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/retitle Fix formatting issues for tab panes |
@@ -38,6 +38,7 @@ The following methods exist for installing kubectl on Linux: | |||
{{< note >}} | |||
To download a specific version, replace the `$(curl -L -s https://dl.k8s.io/release/stable.txt)` | |||
portion of the command with the specific version. | |||
{{< /note >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but this change to move the note
shortcode doesn’t look correct. It seems the current changes in the PR does not align with the reported issue’s requirements. The issue #48813 reports that the tab content not include a full bounding box. For clarity, you can refer to the link of the same page for older version of docs (here) to see the expected appearance.
- Current tab content appearance on the website
- Expected tab content appearance after addressing the issue
- Deployed preview of tab content with this PR change
Hope these links help with understanding the required change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Issue
content/en/docs/tasks/tools/install-kubectl-linux.md
Closes: #48813