Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issues for tab panes #48847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix formatting issues for tab panes #48847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/tasks/tools/install-kubectl-linux.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ The following methods exist for installing kubectl on Linux:
{{< note >}}
To download a specific version, replace the `$(curl -L -s https://dl.k8s.io/release/stable.txt)`
portion of the command with the specific version.
{{< /note >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but this change to move the note shortcode doesn’t look correct. It seems the current changes in the PR does not align with the reported issue’s requirements. The issue #48813 reports that the tab content not include a full bounding box. For clarity, you can refer to the link of the same page for older version of docs (here) to see the expected appearance.

Hope these links help with understanding the required change!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For added clarity, here’s a screenshot from the issue that shows the problem.

image


For example, to download version {{< skew currentPatchVersion >}} on Linux x86-64, type:

Expand All @@ -51,7 +52,6 @@ The following methods exist for installing kubectl on Linux:
curl -LO https://dl.k8s.io/release/v{{< skew currentPatchVersion >}}/bin/linux/arm64/kubectl
```

{{< /note >}}

1. Validate the binary (optional)

Expand Down