-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: verification of the python openshift requirement #595
fix: verification of the python openshift requirement #595
Conversation
Hi @nestoracunablanco. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
automation/unit-tests.sh
Outdated
@@ -1,6 +1,9 @@ | |||
#!/bin/bash | |||
set -ex | |||
|
|||
# dependency check | |||
pip show openshift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make it quiet, so if openshift is installed, it would not print package information into the log?
pip show -q openshift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
dc14595
to
f0f586b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The unit-tests.sh script may fail at an advanced stage if the python openShift module is not installed. Failing at the initial step alerts the user to this requirement. Signed-off-by: Nestor Acuna Blanco <[email protected]>
f0f586b
to
e74173f
Compare
@nestoracunablanco: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The change failed because the pip command could not be found in the container. After reviewing the following file, I believed my last commit would resolve the issue. Unfortunately, that was not the case; it’s possible that the Dockerfile is being sourced from the main branch. |
The unit-tests.sh script may fail at an advanced stage if the python openShift module is not installed. Failing at the initial step alerts the user to this requirement.
What this PR does / why we need it: Fail early
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: