Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CGO when running unit-tests #77

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jschintag
Copy link
Contributor

When running unit-tests, go tries to compile using CGO, despite not needing it. This can lead to errors on systems not having gcc installed, or named wrongly.

What this PR does / why we need it:
Disable CGO for running unit-tests

Special notes for your reviewer:

When running unit-tests, go tries to compile using CGO, despite not needing it.
This can lead to errors on systems not having gcc installed, or named wrongly.

Signed-off-by: Jan Schintag <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 3, 2024
Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@oshoval
Copy link
Collaborator

oshoval commented Dec 3, 2024

/approve

we saw this change is required by on kubevirt/project-infra#3797

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@kubevirt-bot kubevirt-bot merged commit 65a18c8 into kubevirt:main Dec 3, 2024
8 checks passed
@jschintag jschintag deleted the unit-test-no-cgo branch December 4, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants