kubesecondarydns, presubmits: Add build and unit-tests for s390x

[jschintag]

What this PR does / why we need it:
Add testing for building and unit-tests on s390x to kubesecondarydns
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

[oshoval]

Thanks

lgtm basically,

@brianmcarey can you take a look as well please?
it just runs build and unit tests as far as i can tell

[brianmcarey]

/rehearse

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-pull-kubesecondarydns-unit-test-s390x
rehearsal-pull-kubesecondarydns-build-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[oshoval]

interesting
Thanks Brian
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3797/rehearsal-pull-kubesecondarydns-unit-test-s390x/1863963052123099136

please take a look @jschintag

[jschintag]

Should be fixed, for some reason it wanted to use CGO, despite not needing it, and failed to find the gcc binary.

[oshoval]

/rehearse

thanks
shouldnt it be on the makefile ?

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-pull-kubesecondarydns-unit-test-s390x
rehearsal-pull-kubesecondarydns-build-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[jschintag]

Yes i can add it to the makefile as well.

[oshoval]

Yes i can add it to the makefile as well.

better please, lets add it and then remove it from here ?

[jschintag]

Done in kubevirt/kubesecondarydns#77

[oshoval]

/rehearse

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-pull-kubesecondarydns-unit-test-s390x
rehearsal-pull-kubesecondarydns-build-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[oshoval]

/lgtm

@brianmcarey can you ptal ?
should be fine now

[brianmcarey]

/approve

Looks good to me.

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• github/ci/prow-deploy/files/jobs/kubevirt/kubesecondarydns/OWNERS [brianmcarey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-bot]

@jschintag: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

• key kubesecondarydns-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubesecondarydns/kubesecondarydns-presubmits.yaml

In response to this:

What this PR does / why we need it:
Add testing for building and unit-tests on s390x to kubesecondarydns
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[oshoval]

@ashokpariya0
might good to consider please doing the same for CNAO ?
maybe even not always run but optional

[ashokpariya0]

@ashokpariya0 might good to consider please doing the same for CNAO ? maybe even not always run but optional

Okay, Noted.