fix: enclave manager passing in deprecated args object #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
commented
Mar 27, 2024
...r/web/packages/app/src/emui/enclaves/components/enclaveBuilder/nodes/KurtosisPackageNode.tsx
Outdated
Show resolved
Hide resolved
leoporoli
approved these changes
Mar 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Description
The enclave builder would fail to render packages that used `def
run(plan, args)` where starlark in the package depended on values in
`args` being set. This was because the enclave manager was passing args
to interpretation using via an `args`. The use of `args` dict as sole
input is deprecated.
While it's deprecated we still support it for backwards compatibility
but everything in `args` is dropped - which caused the failure. This PR
fixes it by unpacking the values in `args` so enclave builder passes
them as unpacked `kwargs` to interpretation, as opposed to using the
sole deprecated `args` dict.
I've also added a test to highlight this behavior.
```
def run(plan, args):
all_arg_values = args["arg1"] + ":" + args["arg2"]
return all_arg_values
```
will error when passing input with only `args`
`{"args": {"arg1": "arg1-value", "arg2": "arg2-value"}}`
## Is this change user facing?
NO
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.88.12](0.88.11...0.88.12) (2024-03-27) ### Bug Fixes * enclave manager passing in deprecated args object ([#2342](#2342)) ([2bba1bc](2bba1bc)) * starlark -> plan for validator ([#2343](#2343)) ([0dca278](0dca278)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The enclave builder would fail to render packages that used
def run(plan, args)where starlark in the package depended on values inargsbeing set. This was because the enclave manager was passing args to interpretation using via anargs. The use ofargsdict as sole input is deprecated.While it's deprecated we still support it for backwards compatibility but everything in
argsis dropped - which caused the failure. This PR fixes it by unpacking the values inargsso enclave builder passes them as unpackedkwargsto interpretation, as opposed to using the sole deprecatedargsdict.I've also added a test to highlight this behavior.
will error when passing input with only
args{"args": {"arg1": "arg1-value", "arg2": "arg2-value"}}Is this change user facing?
NO