fix: enclave manager passing in deprecated args object

core/server/api_container/server/startosis_engine/startosis_interpreter_test.go

@@ -160,6 +160,31 @@ def my_func(my_arg1, my_arg2, args):
 	require.Equal(suite.T(), expectedResult, result)
 }
 
+func (suite *StartosisInterpreterTestSuite) TestStartosisInterpreter_MainFunctionAndParamsErrWhenOnlyDeprecatedArgsObjectProvided() {
+	script := `
+def run(plan, args):
+	all_arg_values = args["arg1"] + ":" + args["arg2"]
+	return all_arg_values
+`
+	mainFunctionName := "run"
+	// passing in only "args" dictionary is deprecated
+	inputArgs := `{"args": {"arg1": "arg1-value", "arg2": "arg2-value"}}`
+
+	_, _, interpretationError := suite.interpreter.Interpret(context.Background(), startosis_constants.PackageIdPlaceholderForStandaloneScript, mainFunctionName, noPackageReplaceOptions, startosis_constants.PlaceHolderMainFileForPlaceStandAloneScript, script, inputArgs, defaultNonBlockingMode, emptyEnclaveComponents, emptyInstructionsPlanMask, defaultImageDownloadMode)
+	require.NotNil(suite.T(), interpretationError)
+	require.Equal(suite.T(), "Evaluation error: key \"arg1\" not in dict\n\tat [3:23]: run", interpretationError.GetErrorMessage())
+
+	scriptWithKwarg := `
+def run(plan, arg0, args):
+	all_arg_values = arg0 + args["arg1"] + ":" + args["arg2"]
+	return all_arg_values
+`
+	// however passing in kwargs, with args at the end is still fine
+	inputArgsWithKwarg := `{"arg0": "foo", "args": {"arg1": "arg1-value", "arg2": "arg2-value"}}`
+	_, _, interpretationError = suite.interpreter.Interpret(context.Background(), startosis_constants.PackageIdPlaceholderForStandaloneScript, mainFunctionName, noPackageReplaceOptions, startosis_constants.PlaceHolderMainFileForPlaceStandAloneScript, scriptWithKwarg, inputArgsWithKwarg, defaultNonBlockingMode, emptyEnclaveComponents, emptyInstructionsPlanMask, defaultImageDownloadMode)
+	require.Nil(suite.T(), interpretationError)
+}
+
 func (suite *StartosisInterpreterTestSuite) TestStartosisInterpreter_Test() {
 	script := `
 def run(plan):

enclave-manager/web/packages/app/src/emui/enclaves/components/enclaveBuilder/nodes/KurtosisPackageNode.tsx

@@ -26,7 +26,7 @@ export const KurtosisPackageNode = memo(
 
     useEffect(() => {
       const packageId = nodeData?.packageId;
-      const args = nodeData?.args;
+      let args = nodeData?.args;
       if (isDefined(packageId) && isDefined(args) && packageId !== "") {
         let cancelled = false;
         (async () => {
@@ -40,6 +40,14 @@ export const KurtosisPackageNode = memo(
             setMode({ type: "error", error: "APIC info missing from temporary enclave" });
             return;
           }
+
+          // If args only has one record, and its value is args, ASSUME user is passing args via a JSON or YAML into the args object of def run(plan, args)
+          // via Json or Yaml editor
+          // If only an `args` object is provided, kurtosis will not interpret the value in the args object as passing args via the args dictionary is (technically) deprecated even though it's still allowed
+          if (Object.keys(args).length === 1 && args.hasOwnProperty("args")) {
+            args = args["args"] as Record<string, string>; // TODO(tedi): ideally we'd validate and handle this in transform args utils
+          }
+
           const plan = await kurtosisClient.getStarlarkPackagePlanYaml(
             enclave.value.enclaveInfo.apiContainerInfo,
             packageId,