feat: Update tests to use vlan as string instead of int #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniarck
reviewed
Mar 2, 2023
There was a problem hiding this comment.
@ajoaoff thanks for this PR, great to have this covered.
I went ahead and mapped this blocking issue on sdntrace_cp kytos-ng/sdntrace_cp#78 feel free to coordinate with @gretelliz, we'll need this land this one as well. After that, when you execute the e2e if you could also post the results that expedite and facilitate the review as well, much appreciated.
|
I'll go ahead and close this since requirements have changed and kytos-ng/flow_manager#135 landed with more gradual approach. e2e test case with a mask ("any" -> "4096/4096") is also being covered on PR #210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PR kytos-ng/flow_manager#135 arrives the flows will have
dl_vlanstored as strings, so the tests need to compare the stored flowsdl_vlanwith strings.PS: This PR should be merge with kytos-ng/flow_manager#135