Added e2e tests for untagged and any new EVCs #210

Alopalao · 2023-03-03T14:18:12Z

Summary

Tests including the recent addition to vlan available values untagged and any.

Local Tests

tests/test_e2e_20_flow_manager.py ....................                   [ 39%]
tests/test_e2e_21_flow_manager.py ..                                     [ 43%]
tests/test_e2e_22_flow_manager.py ...............                        [ 72%]
tests/test_e2e_23_flow_manager.py ..............                         [100%]

tests/test_e2e_21_flow_manager.py

viniarck

@Alopalao great e2e cov.

Did you also run this locally?

tests/test_e2e_10_mef_eline.py

Alopalao · 2023-03-06T16:06:32Z

Yes, the results are posted on mef_eline PR too,

tests/test_e2e_01_kytos_startup.py ..                                    [  0%]
tests/test_e2e_05_topology.py ..................                         [  9%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x........R.        [ 25%]
tests/test_e2e_11_mef_eline.py .....                                     [ 27%]
tests/test_e2e_12_mef_eline.py .....xx.                                  [ 31%]
tests/test_e2e_13_mef_eline.py .....xxXx......xxXx.XXxX.xxxx..x......... [ 50%]
...                                                                      [ 52%]
tests/test_e2e_14_mef_eline.py x                                         [ 52%]
tests/test_e2e_15_mef_eline.py ..                                        [ 53%]
tests/test_e2e_20_flow_manager.py .....RRF.RRF...........                [ 62%]
tests/test_e2e_21_flow_manager.py ...                                    [ 64%]
tests/test_e2e_22_flow_manager.py ...............                        [ 71%]
tests/test_e2e_23_flow_manager.py ..............                         [ 78%]
tests/test_e2e_30_of_lldp.py ....                                        [ 80%]
tests/test_e2e_31_of_lldp.py R...                                        [ 81%]
tests/test_e2e_32_of_lldp.py ...                                         [ 82%]
tests/test_e2e_40_sdntrace.py RRF.RRFRRF                                 [ 84%]
tests/test_e2e_41_kytos_auth.py ........                                 [ 88%]
tests/test_e2e_50_maintenance.py ........................                [100%]

viniarck · 2023-03-06T16:10:24Z

tests/test_e2e_10_mef_eline.py

+        h11.cmd('ip addr add 100.0.0.11/24 dev vlan100')
+        h2.cmd('ip link add link %s name vlan100 type vlan id 100' % (h2.intfNames()[0]))
+        h2.cmd('ip link set up vlan100')
+        h2.cmd('ip addr add 100.0.0.2/24 dev vlan100')


symmetric hosts VLANs I think it's fair game to test this use case, but let's also assert the installed UNI flows on the switches based on your spreadsheet for completeness. @italovalcy let us know if you'd like to see this tested differently.

I believe it is worth adding assertions on the flows besides doing the ping test. Especially since we don't have tests for asymmetric VLANs so far.

I divided the PR, here is the correct one for mef_eline

viniarck · 2023-03-06T16:15:22Z

Yes, the results are posted on mef_eline PR too,

tests/test_e2e_01_kytos_startup.py ..                                    [  0%]
tests/test_e2e_05_topology.py ..................                         [  9%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x........R.        [ 25%]
tests/test_e2e_11_mef_eline.py .....                                     [ 27%]
tests/test_e2e_12_mef_eline.py .....xx.                                  [ 31%]
tests/test_e2e_13_mef_eline.py .....xxXx......xxXx.XXxX.xxxx..x......... [ 50%]
...                                                                      [ 52%]
tests/test_e2e_14_mef_eline.py x                                         [ 52%]
tests/test_e2e_15_mef_eline.py ..                                        [ 53%]
tests/test_e2e_20_flow_manager.py .....RRF.RRF...........                [ 62%]
tests/test_e2e_21_flow_manager.py ...                                    [ 64%]
tests/test_e2e_22_flow_manager.py ...............                        [ 71%]
tests/test_e2e_23_flow_manager.py ..............                         [ 78%]
tests/test_e2e_30_of_lldp.py ....                                        [ 80%]
tests/test_e2e_31_of_lldp.py R...                                        [ 81%]
tests/test_e2e_32_of_lldp.py ...                                         [ 82%]
tests/test_e2e_40_sdntrace.py RRF.RRFRRF                                 [ 84%]
tests/test_e2e_41_kytos_auth.py ........                                 [ 88%]
tests/test_e2e_50_maintenance.py ........................                [100%]

Nice. sdntrace_cp failing is expected until this issue kytos-ng/sdntrace_cp#78 is addressed. I've noticed some reruns on this output here, later on I'll also recommend for you to run each test isolated here and keep eye on reruns they're not usually expected when tests are stable and written in way that favor deterministic execution.

tests/test_e2e_21_flow_manager.py

italovalcy · 2023-03-07T16:30:27Z

tests/test_e2e_10_mef_eline.py

+        time.sleep(10)
+
+        h11, h2 = self.net.net.get('h11', 'h2')
+        h11.cmd('ip link add link %s name vlan100 type vlan id 100' % (h11.intfNames()[0]))


Since we are using the "any" VLAN here, what do you think about using a random value for the VLAN on the PING test? I suggest replacing the VLAN 100 with a random value chosen from a range from 1 to 4095. Let me know what you think.

Sure, will do that.

I divided the PR, here is the correct one for mef_eline

viniarck · 2023-03-08T16:34:14Z

Yes, the results are posted on mef_eline PR too,

tests/test_e2e_01_kytos_startup.py ..                                    [  0%]
tests/test_e2e_05_topology.py ..................                         [  9%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x........R.        [ 25%]
tests/test_e2e_11_mef_eline.py .....                                     [ 27%]
tests/test_e2e_12_mef_eline.py .....xx.                                  [ 31%]
tests/test_e2e_13_mef_eline.py .....xxXx......xxXx.XXxX.xxxx..x......... [ 50%]
...                                                                      [ 52%]
tests/test_e2e_14_mef_eline.py x                                         [ 52%]
tests/test_e2e_15_mef_eline.py ..                                        [ 53%]
tests/test_e2e_20_flow_manager.py .....RRF.RRF...........                [ 62%]
tests/test_e2e_21_flow_manager.py ...                                    [ 64%]
tests/test_e2e_22_flow_manager.py ...............                        [ 71%]
tests/test_e2e_23_flow_manager.py ..............                         [ 78%]
tests/test_e2e_30_of_lldp.py ....                                        [ 80%]
tests/test_e2e_31_of_lldp.py R...                                        [ 81%]
tests/test_e2e_32_of_lldp.py ...                                         [ 82%]
tests/test_e2e_40_sdntrace.py RRF.RRFRRF                                 [ 84%]
tests/test_e2e_41_kytos_auth.py ........                                 [ 88%]
tests/test_e2e_50_maintenance.py ........................                [100%]

@Alopalao I've closed the threads that I opened. Thanks for pushing these updates. Other than the threads that you're aligning with Italo, when it's done, please rerun e2e selecting flow_manager related tests.

Also, another piece of advice will be to break this PR in two, since mef_eline PR is still in review, if you split it in two, covering flow_manager here and mef_eline on another one then of_core PR kytos-ng/of_core#98 could land soon as well once this PR here is approved. You could still keep both but it will sit longer in code review.

viniarck

LGTM. I'll leave this PR approved since Aldo managed to split the PRs to simplify the review and the open discussions will continue on PR #213

@Alopalao, can you rerun one last time test_032_on_switch_reconnection_should_recreate_untagged_any_flows to ensure it doesn't have any auto-rerun from pytest?

Alopalao · 2023-03-09T15:26:21Z

New build test results:

tests/test_e2e_20_flow_manager.py ....................                   [ 39%]
tests/test_e2e_21_flow_manager.py ..                                     [ 43%]
tests/test_e2e_22_flow_manager.py ...............                        [ 72%]
tests/test_e2e_23_flow_manager.py ..............                         [100%]

italovalcy

LGTM. Thanks for sending this PR to cover the changes on flow_manger and of_core, Aldo! Very well done.

Added e2e tests for untagged and any new EVCs

450ca4d

Alopalao mentioned this pull request Mar 3, 2023

feature: Allow creation for "any" and "untagged" as EVCs kytos-ng/mef_eline#258

Merged

viniarck requested review from italovalcy and a team March 6, 2023 15:25

viniarck reviewed Mar 6, 2023

View reviewed changes

tests/test_e2e_21_flow_manager.py Outdated Show resolved Hide resolved

viniarck self-requested a review March 6, 2023 16:01

viniarck reviewed Mar 6, 2023

View reviewed changes

tests/test_e2e_10_mef_eline.py Outdated Show resolved Hide resolved

viniarck reviewed Mar 6, 2023

View reviewed changes

tests/test_e2e_21_flow_manager.py Show resolved Hide resolved

viniarck mentioned this pull request Mar 6, 2023

Added a way to handle 4096/4096 and 0 kytos-ng/of_core#98

Merged

italovalcy reviewed Mar 7, 2023

View reviewed changes

Added additional tests

4b1b75d

Divided PRs

e316016

viniarck requested review from italovalcy and viniarck March 8, 2023 17:44

viniarck approved these changes Mar 8, 2023

View reviewed changes

viniarck mentioned this pull request Mar 9, 2023

feat: Update tests to use vlan as string instead of int #209

Closed

italovalcy approved these changes Mar 14, 2023

View reviewed changes

Alopalao merged commit a6b9a56 into kytos-ng:master Mar 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added e2e tests for untagged and any new EVCs #210

Added e2e tests for untagged and any new EVCs #210

Alopalao commented Mar 3, 2023 •

edited

Loading

viniarck left a comment

Alopalao commented Mar 6, 2023 •

edited

Loading

viniarck Mar 6, 2023

italovalcy Mar 7, 2023

Alopalao Mar 8, 2023

Alopalao Mar 8, 2023

viniarck commented Mar 6, 2023

italovalcy Mar 7, 2023

Alopalao Mar 7, 2023

Alopalao Mar 8, 2023

viniarck commented Mar 8, 2023

viniarck left a comment

Alopalao commented Mar 9, 2023

italovalcy left a comment

Added e2e tests for untagged and any new EVCs #210

Added e2e tests for untagged and any new EVCs #210

Conversation

Alopalao commented Mar 3, 2023 • edited Loading

Summary

Local Tests

viniarck left a comment

Choose a reason for hiding this comment

Alopalao commented Mar 6, 2023 • edited Loading

viniarck Mar 6, 2023

Choose a reason for hiding this comment

italovalcy Mar 7, 2023

Choose a reason for hiding this comment

Alopalao Mar 8, 2023

Choose a reason for hiding this comment

Alopalao Mar 8, 2023

Choose a reason for hiding this comment

viniarck commented Mar 6, 2023

italovalcy Mar 7, 2023

Choose a reason for hiding this comment

Alopalao Mar 7, 2023

Choose a reason for hiding this comment

Alopalao Mar 8, 2023

Choose a reason for hiding this comment

viniarck commented Mar 8, 2023

viniarck left a comment

Choose a reason for hiding this comment

Alopalao commented Mar 9, 2023

italovalcy left a comment

Choose a reason for hiding this comment

Alopalao commented Mar 3, 2023 •

edited

Loading

Alopalao commented Mar 6, 2023 •

edited

Loading