-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for untagged and any from mef_eline changes #213
Conversation
tests/test_e2e_10_mef_eline.py
Outdated
|
||
api_url = KYTOS_API + '/flow_manager/v2/flows/00:00:00:00:00:00:00:01' | ||
response = requests.get(api_url) | ||
data = response.json()["00:00:00:00:00:00:00:01"]["flows"][2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sequential list access [2]
on the output list of v2/flows/dpid
one day might backfire. Usually, flows are returned on priority, if we ended up with other higher priority flows from other NApps it could also break this test. Since the list of the flows is expected to be relatively small it's ok to iterate on it, maybe you could refactor this part trying making sure that at least of the entries matches with the expected
dict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a helper function to search for a expected dict flow in a list would be handy to reuse on other tests too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new function get_flow_by_vlan_match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alopalao looks great to me. Nicely done covering the cases, including with inter and intra EVCs as well. The spreadsheet that you created facilitated a lot to review (and it'll be linked int the release notes), so much appreciated you creating that as well.
I'll leave this PR for @italovalcy to finish the review since you both have already been collaborating on a related review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done, @Alopalao. The overall PR looks good to me. I just left a few suggestion to remove kytos restart calls because this will already happen as part of the setup_method
.
Related to mef_eline PR
Summary
Tests including the recent addition to
vlan
available valuesuntagged
andany
.Local Tests