Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add vlan range support to DB models #319

Closed
wants to merge 2 commits into from

Conversation

ajoaoff
Copy link

@ajoaoff ajoaoff commented Apr 25, 2023

Modify TAGDoc validation allowing a string with <int>-<int> format.

Fixes #318

@ajoaoff ajoaoff requested a review from a team as a code owner April 25, 2023 19:55
db/models.py Outdated Show resolved Hide resolved
@ajoaoff
Copy link
Author

ajoaoff commented May 3, 2023

I may still contribute, but not regurlarly, so I can’t commit to have this finished for 2023.1

@viniarck
Copy link
Member

viniarck commented May 3, 2023

I may still contribute, but not regurlarly, so I can’t commit to have this finished for 2023.1

Right @ajoaoff. Much appreciated all of your contributions over the past years. Let's leave this PR as it is for now then. I'll double check with the team if any other core team member will be able to pick it up, otherwise we'll defer it to a next release.

@viniarck
Copy link
Member

viniarck commented May 8, 2023

On today's meeting we decided to deprioritize this epic from 2023.1 since the other core developers were already with other epics that also have high priority. This PR looks good, but it'll set it as a draft, in the future someone will pick it up again, once the rest of the related tasks are prioritized too.

Thanks, Antonio.

@viniarck viniarck marked this pull request as draft May 8, 2023 20:50
@viniarck
Copy link
Member

viniarck commented Nov 3, 2023

@ajoaoff, once again, our team appreciated all your contributions and this PR, however, vlan range has evolved and the data model will use list[list[int]] instead that @Alopalao has specified kytos-ng/kytos#422 and it'll be implemented. So, I'll go ahead and close this PR here.

@viniarck viniarck closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EVC models to accept a vlan range
2 participants