Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vlan_range support #407

Merged
merged 12 commits into from
Nov 22, 2023
Merged

Added vlan_range support #407

merged 12 commits into from
Nov 22, 2023

Conversation

Alopalao
Copy link

Closes #18
Closes #309

Summary

This PR needs kytos PR
Added support for vlan_range epic. Currently only when both UNIs have the same list of tags

Local Tests

  • Created, updated and deleted circuit.
  • Restarted kytos to check consistency work. Partial updates for list of tags also tested. For example if both UNI have [[20, 30]] and they are being updated to [[25, 30]].
  • Added and updated tests.

End-To-End Tests

============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.3.0
rootdir: /tests
plugins: timeout-2.1.0, rerunfailures-10.2, anyio-3.6.2
collected 244 items

tests/test_e2e_01_kytos_startup.py ..                                    [  0%]
tests/test_e2e_05_topology.py ..................                         [  8%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x................  [ 24%]
tests/test_e2e_11_mef_eline.py ......                                    [ 27%]
tests/test_e2e_12_mef_eline.py .....Xx.                                  [ 30%]
tests/test_e2e_13_mef_eline.py ....Xs.s.....Xs.s.XXxX.xxxx..X........... [ 47%]
.                                                                        [ 47%]
tests/test_e2e_14_mef_eline.py x                                         [ 47%]
tests/test_e2e_15_mef_eline.py ....                                      [ 49%]
tests/test_e2e_20_flow_manager.py .....................                  [ 58%]
tests/test_e2e_21_flow_manager.py ...                                    [ 59%]
tests/test_e2e_22_flow_manager.py ...............                        [ 65%]
tests/test_e2e_23_flow_manager.py ..............                         [ 71%]
tests/test_e2e_30_of_lldp.py ....                                        [ 72%]
tests/test_e2e_31_of_lldp.py ...                                         [ 74%]
tests/test_e2e_32_of_lldp.py ...                                         [ 75%]
tests/test_e2e_40_sdntrace.py .............                              [ 80%]
tests/test_e2e_41_kytos_auth.py ........                                 [ 84%]
tests/test_e2e_42_sdntrace.py ..                                         [ 84%]
tests/test_e2e_50_maintenance.py ........................                [ 94%]
tests/test_e2e_60_of_multi_table.py .....                                [ 96%]
tests/test_e2e_70_kytos_stats.py ........                                [100%]

@Alopalao Alopalao requested a review from a team as a code owner November 21, 2023 18:07
@Alopalao Alopalao changed the title Epic/vlan range copy Added vlan_range support Nov 21, 2023
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @Alopalao. LGTM. Network operators were really looking forward to this vlan range feature. I'm glad you've also sorted out the overwritten git history commits. Let's ship this once #383 gets merged (as we've been discussing in other communication channels)

@viniarck viniarck requested a review from a team November 21, 2023 18:39
Base automatically changed from fix/handle_switch_changes to master November 22, 2023 12:43
@viniarck viniarck merged commit f826757 into master Nov 22, 2023
2 checks passed
@viniarck viniarck deleted the epic/vlan_range_copy branch November 22, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update _prepare_uni_flows to deal with VLAN ranges Add support to VLAN range
2 participants