pyproject.toml: depend on pylint rather than pytest-pylint #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labgrid's tests have never been linted, so there is no need to install pytest-pylint. Install pylint instead to allow linting of the labgrid module. Require at least version 3.0.0 of pylint which will be required for Python 3.12 anyway [1]. [1] https://github.com/pylint-dev/pylint/releases/tag/v3.0.0 Signed-off-by: Bastian Krause <[email protected]>
7 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
========================================
- Coverage 63.0% 63.0% -0.1%
========================================
Files 160 160
Lines 11859 11859
========================================
- Hits 7481 7479 -2
- Misses 4378 4380 +2 ☔ View full report in Codecov by Sentry. |
4 tasks
Emantor
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
labgrid's tests have never been linted, so there is no need to install pytest-pylint. Install pylint instead to allow linting of the labgrid module.
Require at least version 3.0.0 of pylint which will be required for Python 3.12 anyway [1].
This also allows us to work around carsongee/pytest-pylint#180 which currently makes our CI tests fail.
[1] https://github.com/pylint-dev/pylint/releases/tag/v3.0.0
Checklist