-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve empty value display in DoubleTag
and update BAIIntervalView
#2813
fix: resolve empty value display in DoubleTag
and update BAIIntervalView
#2813
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on Graphite |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.02% (-0.02% 🔻) |
367/7318 |
🔴 | Branches | 4.4% (+0.01% 🔼) |
221/5027 |
🔴 | Functions | 2.94% (-0.01% 🔻) |
71/2414 |
🔴 | Lines | 4.92% (-0.02% 🔻) |
352/7157 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / BAIIntervalView.tsx |
0% | 0% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | hooks/index.tsx | 37.96% (-4.67% 🔻) |
24.39% (-3.39% 🔻) |
19.51% (-1.54% 🔻) |
37.31% (-4.7% 🔻) |
🔴 | helper/index.tsx | 50.97% (-1.35% 🔻) |
47.22% | 39.47% (-1.07% 🔻) |
52.24% (-1.61% 🔻) |
Test suite run success
109 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 9c66cb1
498cfd6
to
622b3db
Compare
622b3db
to
0d11bdd
Compare
0d11bdd
to
f42a71f
Compare
f42a71f
to
2c6d6e1
Compare
BAIIntervalText
with BAIIntervalView
and add render prop
BAIIntervalText
with BAIIntervalView
and add render propDoubleTag
and update BAIIntervalView
2c6d6e1
to
711bb98
Compare
711bb98
to
9c66cb1
Compare
9c66cb1
to
3ccf2e1
Compare
8c89ece
to
4b7ae74
Compare
3ccf2e1
to
7c251ec
Compare
4b7ae74
to
0a90887
Compare
7c251ec
to
509c379
Compare
0a90887
to
64a56cd
Compare
509c379
to
98ef302
Compare
64a56cd
to
482c0ac
Compare
98ef302
to
f644e87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
…alView` (#2813) **Changes:** - Replaced `BAIIntervalText` with new `BAIIntervalView` component that supports render props - Updated `DoubleTag` component to handle string highlighting and simplified value types - Refactored tag rendering to use object-based values consistently - Added type safety improvements for tag labels and values **Rationale:** Improves component reusability and type safety by introducing a more flexible interval view component with render prop support. Standardizes the way tags are rendered across the application while adding proper highlighting capabilities. **How to test:** 1. Check agent list running time displays correctly 2. Verify session elapsed time shows properly 3. Test customized image tags display correctly Example usage: ```tsx <BAIIntervalView callback={() => baiClient.utils.elapsedTime(value, Date.now())} delay={1000} render={(intervalValue) => ( <DoubleTag values={[ { label: 'Running' }, { label: intervalValue } ]} /> )} /> ``` **Checklist:** - [ ] Test interval updates across all usage locations - [ ] Verify tag highlighting works with search functionality - [ ] Check type safety of tag value props - [ ] Ensure backwards compatibility with existing tag implementations **Screenshots:** Before ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/497082c2-e79a-43bd-a86a-70554e2984c3.png) After ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/9b654ec0-cfa6-400d-88d4-bd1cebcd99a2.png)
482c0ac
to
506a1a1
Compare
f644e87
to
7bb0c92
Compare
Changes:
BAIIntervalText
with newBAIIntervalView
component that supports render propsDoubleTag
component to handle string highlighting and simplified value typesRationale:
Improves component reusability and type safety by introducing a more flexible interval view component with render prop support. Standardizes the way tags are rendered across the application while adding proper highlighting capabilities.
How to test:
Example usage:
Checklist:
Screenshots:
Before
After