Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add image util functions test #2821

Merged
merged 1 commit into from
Nov 12, 2024
Merged

test: add image util functions test #2821

merged 1 commit into from
Nov 12, 2024
+139 −47

Conversation

agatha197
Copy link
Contributor

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 mentioned this pull request Nov 6, 2024
Merged
6 tasks
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 6, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@agatha197 Graphite App
Copy link
Contributor Author

agatha197 commented Nov 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

This was referenced Nov 6, 2024
Merged
Merged
@github-actions github-actions bot added the size:L 100~500 LoC label Nov 6, 2024
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from e12704a to b22b627 Compare November 6, 2024 02:53
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 69e3cce to a969f2b Compare November 6, 2024 02:53
@yomybaby yomybaby force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from b22b627 to e256c11 Compare November 6, 2024 04:42
@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from a969f2b to 7f3057a Compare November 6, 2024 04:43
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from e256c11 to 6445e5b Compare November 6, 2024 04:59
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 7f3057a to cb457a2 Compare November 6, 2024 04:59
@agatha197 agatha197 mentioned this pull request Nov 6, 2024
Merged
6 tasks
@agatha197 agatha197 added the urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. label Nov 6, 2024 — with Graphite App
@agatha197 agatha197 added this to the 24.09 milestone Nov 6, 2024
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 6445e5b to 4f66088 Compare November 6, 2024 07:42
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from cb457a2 to c95f3bb Compare November 6, 2024 07:42
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 4f66088 to 3f70242 Compare November 6, 2024 07:54
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from c95f3bb to a0eef13 Compare November 6, 2024 07:54
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 3f70242 to 6ef74c3 Compare November 6, 2024 08:01
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from a0eef13 to 75be312 Compare November 6, 2024 08:01
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 6ef74c3 to a662400 Compare November 7, 2024 05:30
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 75be312 to 41e7bf3 Compare November 7, 2024 05:31
@yomybaby yomybaby force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from a662400 to 38fc810 Compare November 7, 2024 09:04
@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from 41e7bf3 to d0da32f Compare November 7, 2024 09:04
@yomybaby yomybaby mentioned this pull request Nov 7, 2024
Merged
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 38fc810 to 5cb9459 Compare November 11, 2024 00:55
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from d0da32f to ff086a3 Compare November 11, 2024 00:55
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 5cb9459 to 01d1980 Compare November 11, 2024 05:26
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from ff086a3 to 52c9cdc Compare November 11, 2024 05:26
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 01d1980 to b814fbf Compare November 11, 2024 05:29
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 52c9cdc to 8a150e9 Compare November 11, 2024 05:29
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from b814fbf to 162bc3b Compare November 12, 2024 07:52
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 8a150e9 to 882b8e0 Compare November 12, 2024 07:52
@agatha197 agatha197 mentioned this pull request Nov 12, 2024
Merged
4 tasks
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 162bc3b to 4f68e12 Compare November 12, 2024 08:24
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 882b8e0 to 4717484 Compare November 12, 2024 08:24
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 4f68e12 to 18df098 Compare November 12, 2024 08:32
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 4717484 to 5d06299 Compare November 12, 2024 08:32
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 18df098 to 983a8a6 Compare November 12, 2024 08:36
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 5d06299 to a59e849 Compare November 12, 2024 08:36
@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from a59e849 to 0edf30c Compare November 12, 2024 08:45
@yomybaby yomybaby changed the base branch from refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 to fix/remove-tag-when-label-has-empty-children November 12, 2024 08:45
@yomybaby yomybaby changed the base branch from fix/remove-tag-when-label-has-empty-children to graphite-base/2821 November 12, 2024 08:57
@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from 0edf30c to 853adcc Compare November 12, 2024 09:00
@yomybaby yomybaby changed the base branch from graphite-base/2821 to main November 12, 2024 09:00
@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from 853adcc to 42911e5 Compare November 12, 2024 09:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
5.27% (+0.26% 🔼)
 386/7319
🔴 Branches
4.56% (+0.16% 🔼)
 229/5027
🔴 Functions
3.15% (+0.21% 🔼)
 76/2414
🔴 Lines
5.18% (+0.26% 🔼)
 371/7158

Test suite run success

109 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 0479273

@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from 42911e5 to 76d12f2 Compare November 12, 2024 09:02
yomybaby
yomybaby approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not copy the function code for testing. If it's a pure function, export it separately. For hooks, mock them when writing tests.

I pushed changes to export it separately.
LGTM, now!
Thank you 😉

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 12, 2024 •
edited
Loading

Merge activity

@agatha197
test: add image util functions test (#2821)
0479273 
<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from 76d12f2 to 0479273 Compare November 12, 2024 09:06
@graphite-app graphite-app bot merged commit 0479273 into main Nov 12, 2024
6 checks passed
@graphite-app graphite-app bot deleted the feature/add-image-util-functions-test branch November 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

@ironAiken2 ironAiken2 Awaiting requested review from ironAiken2

Assignees

@agatha197 agatha197

Labels
size:L 100~500 LoC urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
24.09
Development

Successfully merging this pull request may close these issues.
2 participants
@agatha197 @yomybaby