Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-319): Session list NEO #2932

Draft
wants to merge 7 commits into
base: refactor/undefined-controlled-value-in-baipropertyfilter
Choose a base branch
from

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Dec 10, 2024

Resolves #3000 (FR-319)

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Dec 10, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:L 100~500 LoC label Dec 10, 2024
Copy link
Member Author

yomybaby commented Dec 10, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 changed the base branch from feature/strict-mode-bai-propert-filter to graphite-base/2932 December 10, 2024 06:38
@ironAiken2 ironAiken2 force-pushed the feature/session-list-neo branch from e069c25 to f4855be Compare December 10, 2024 06:40
@ironAiken2 ironAiken2 changed the base branch from graphite-base/2932 to main December 10, 2024 06:41
@ironAiken2 ironAiken2 force-pushed the feature/session-list-neo branch from f4855be to 1e040af Compare December 10, 2024 06:41
@yomybaby yomybaby force-pushed the feature/session-list-neo branch 2 times, most recently from 483ddb7 to d3fe67a Compare December 11, 2024 10:26
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Dec 11, 2024
@yomybaby yomybaby force-pushed the feature/session-list-neo branch 2 times, most recently from 523dce8 to 092bc4f Compare December 11, 2024 10:31
Copy link

github-actions bot commented Dec 11, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.2% (-0.03% 🔻)
398/7652
🔴 Branches
4.47% (-0.03% 🔻)
237/5306
🔴 Functions
3.1% (-0.03% 🔻)
78/2514
🔴 Lines
5.12% (-0.03% 🔻)
383/7483
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / ComputeSessionListPage.tsx
0% 0% 0% 0%
🔴
... / SessionNodes.tsx
0% 0% 0% 0%
🔴
... / ComputeSessionNodeList.tsx
0% 100% 0% 0%
🔴
... / SessionOccupiedSlot.tsx
0% 0% 0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from e947593

@yomybaby yomybaby force-pushed the feature/session-list-neo branch 2 times, most recently from e947593 to 85e642c Compare December 12, 2024 08:41
@yomybaby yomybaby force-pushed the feature/session-list-neo branch from 85e642c to 2cb5723 Compare January 6, 2025 06:35
@yomybaby yomybaby changed the base branch from main to refactor/undefined-controlled-value-in-baipropertyfilter January 6, 2025 06:35
@yomybaby yomybaby changed the title feat: Session list NEO feat(FR-319): Session list NEO Jan 23, 2025
@yomybaby yomybaby linked an issue Jan 23, 2025 that may be closed by this pull request
@yomybaby yomybaby force-pushed the refactor/undefined-controlled-value-in-baipropertyfilter branch from 059d576 to 0d3fa3e Compare January 31, 2025 03:13
@yomybaby yomybaby force-pushed the feature/session-list-neo branch from 2cb5723 to 0219a74 Compare January 31, 2025 03:13
@yomybaby yomybaby force-pushed the refactor/undefined-controlled-value-in-baipropertyfilter branch from 0d3fa3e to e8aa9e4 Compare January 31, 2025 11:17
@yomybaby yomybaby force-pushed the feature/session-list-neo branch from 0219a74 to e401c34 Compare January 31, 2025 11:17
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEO: Basic session list table and filters
1 participant