refactor(FR-460): handle undefined value as controlled value in BAIPropertyFilter #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.9% (-0% 🔻) |
398/8119 |
| 🔴 | Branches | 4.24% | 239/5636 |
| 🔴 | Functions | 2.95% (-0% 🔻) |
78/2644 |
| 🔴 | Lines | 4.82% (-0% 🔻) |
383/7942 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / BAIPropertyFilter.tsx |
10.26% (-0.85% 🔻) |
0% | 3.45% (-0.4% 🔻) |
11.27% (-0.67% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 5c179f8
yomybaby
changed the title
yomybaby
changed the title
yomybaby
force-pushed
the
refactor/undefined-controlled-value-in-baipropertyfilter
branch
3 times, most recently
from
e8aa9e4 to
eb05507
Compare
yomybaby
changed the title
Merge activity
|
…opertyFilter (#2999) Resolves #3095 (FR-460) ## Why refactoring? In the `BAIPropertyFilter` component, when the `value` is explicitly set to `undefined`, it should be treated as having no value rather than being in an uncontrolled mode. Currently, this causes issues where the component's internal state does not update when the `value` is changed via props from the parent, rather than being reset by the user. This issue needs to be addressed to ensure proper state management. ## Changes Replaces `useDynamicList` with `useControllableValue` in the BAIPropertyFilter component to improve filter state management. This change: - Introduces key-based filter tracking for more reliable tag removal - Simplifies filter value updates through a centralized update function - Fixes empty string handling in filter parsing - Removes unnecessary effect hook dependencies - Streamlines option generation for the AutoComplete component
graphite-app
bot
force-pushed
the
refactor/undefined-controlled-value-in-baipropertyfilter
branch
from
eb05507 to
5c179f8
Compare
graphite-app
bot
deleted the
refactor/undefined-controlled-value-in-baipropertyfilter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3095 (FR-460)
Why refactoring?
In the
BAIPropertyFiltercomponent, when thevalueis explicitly set toundefined, it should be treated as having no value rather than being in an uncontrolled mode. Currently, this causes issues where the component's internal state does not update when thevalueis changed via props from the parent, rather than being reset by the user. This issue needs to be addressed to ensure proper state management.Changes
Replaces
useDynamicListwithuseControllableValuein the BAIPropertyFilter component to improve filter state management. This change: