Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle undefined value as controlled value in BAIPropertyFilter #2999

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Jan 6, 2025

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:M 30~100 LoC label Jan 6, 2025
@yomybaby yomybaby mentioned this pull request Jan 6, 2025
6 tasks
Copy link
Member Author

yomybaby commented Jan 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 6, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.99% (+0.01% 🔼)
398/7972
🔴 Branches
4.32% (+0.01% 🔼)
237/5492
🔴 Functions
2.99% (+0.01% 🔼)
78/2609
🔴 Lines
4.91% (+0.01% 🔼)
383/7797
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / BAIPropertyFilter.tsx
10.26% (-0.85% 🔻)
0%
3.45% (-0.4% 🔻)
11.27% (-0.67% 🔻)

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 059d576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant