Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the Export CSV feature from the WebUI #2984

Closed

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Dec 23, 2024

This PR resolves #2985 issue.

Changes:

  • Since WebUI version "24.12.0", the WebUI no longer provides the export CSV feature. For this reason, I removed all existing export CSV functionality.
  • Since the session log modal uses the downloadBlob function, I did not delete that function.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 changed the title fix: delete export csv function in WebUI fix: remove the Export CSV feature from the WebUI Dec 23, 2024
@ironAiken2 ironAiken2 force-pushed the fix/delete-export-csv branch from d89fc57 to 3190d7d Compare December 23, 2024 07:10
@github-actions github-actions bot added area:lib Library and SDK related issue. area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Dec 23, 2024
@ironAiken2 ironAiken2 marked this pull request as ready for review December 23, 2024 07:14
@ironAiken2 ironAiken2 linked an issue Dec 23, 2024 that may be closed by this pull request
@ironAiken2 ironAiken2 closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Export CSV feature from the WebUI
1 participant