-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace vfolder
's status_history
's type map
with list
#2116
base: topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge
Are you sure you want to change the base?
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jopemachine and the rest of your teammates on Graphite |
vfolder
's status_history
's type map
with list
251cc1f
to
8a939e1
Compare
88a37fc
to
f321e18
Compare
7afe46a
to
b6fe378
Compare
f321e18
to
b57682f
Compare
b6fe378
to
0fafe9c
Compare
b57682f
to
4abec88
Compare
0fafe9c
to
b71047f
Compare
4abec88
to
b50a496
Compare
b71047f
to
6759ebb
Compare
b50a496
to
688c0dd
Compare
6759ebb
to
8f10a1e
Compare
688c0dd
to
848b7cb
Compare
8f10a1e
to
750fdc0
Compare
f55c2ca
to
2a73953
Compare
750fdc0
to
16af161
Compare
2a73953
to
23ea8c4
Compare
It is a part of #767.
The current implementation saves only the most recent timestamp whenever status information in status_history is updated, and all previous information is deleted.
This PR prevents the loss of timestamp information by changing the data structure of vfolders' status_history to List.
Checklist: (if applicable)