Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace vfolder's status_history's type map with list #2116

Open
wants to merge 2 commits into
base: topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented May 7, 2024

It is a part of #767.

The current implementation saves only the most recent timestamp whenever status information in status_history is updated, and all previous information is deleted.

This PR prevents the loss of timestamp information by changing the data structure of vfolders' status_history to List.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

Copy link

graphite-app bot commented May 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jopemachine jopemachine marked this pull request as ready for review May 7, 2024 08:12
@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:M 30~100 LoC labels May 7, 2024
Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jopemachine and the rest of your teammates on Graphite Graphite

@jopemachine jopemachine changed the title refactor: Replace vfolder's status_history's type map with list refactor: Replace vfolder's status_history's type map with list May 7, 2024
@jopemachine jopemachine added this to the 24.09 milestone May 7, 2024
@jopemachine jopemachine force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch from 251cc1f to 8a939e1 Compare May 9, 2024 04:43
@jopemachine jopemachine force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from 88a37fc to f321e18 Compare May 9, 2024 04:43
@achimnol achimnol force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch 2 times, most recently from 7afe46a to b6fe378 Compare July 15, 2024 14:23
@achimnol achimnol force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from f321e18 to b57682f Compare July 15, 2024 14:23
@achimnol achimnol force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch from b6fe378 to 0fafe9c Compare July 18, 2024 08:00
@achimnol achimnol force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from b57682f to 4abec88 Compare July 18, 2024 08:00
@jopemachine jopemachine force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch from 0fafe9c to b71047f Compare July 18, 2024 08:19
@jopemachine jopemachine force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from 4abec88 to b50a496 Compare July 18, 2024 08:20
@achimnol achimnol force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch from b71047f to 6759ebb Compare July 22, 2024 16:34
@achimnol achimnol force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from b50a496 to 688c0dd Compare July 22, 2024 16:34
@achimnol achimnol force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch from 6759ebb to 8f10a1e Compare July 22, 2024 16:38
@achimnol achimnol force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from 688c0dd to 848b7cb Compare July 22, 2024 16:38
@achimnol
Copy link
Member

Revised the PR description from "Partially resolves #767" to "It is a part of #767" to prevent accidental closing of the referenced issue as "resolves #NNN" is the pattern to be recognized as the full resolution of the issue.

@achimnol achimnol force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch from 8f10a1e to 750fdc0 Compare July 22, 2024 17:01
@achimnol achimnol force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from f55c2ca to 2a73953 Compare July 22, 2024 17:01
@achimnol achimnol force-pushed the topic/05-07-chore_add_dummy_kernels_for_testing_sql_json_merge branch from 750fdc0 to 16af161 Compare July 23, 2024 06:18
@achimnol achimnol force-pushed the topic/05-07-refactor_replace_vfolder_s_status_history_s_type_map_with_list branch from 2a73953 to 23ea8c4 Compare July 23, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants