refactor: Handle container start error in separate try-catch context #2316
+71
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
comp:agent
This was referenced Jun 20, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
1 task
fregataa
changed the title
fregataa
force-pushed
the
topic/06-20-fix_smelly_error_handling_in_kernel_creation
branch
2 times, most recently
from
3446b86
to
62fd88d
Compare
fregataa
force-pushed
the
topic/05-23-fix_enhanced_kernel_termination_handling
branch
2 times, most recently
from
bd7d1e4
to
25e70f3
Compare
fregataa
force-pushed
the
topic/06-20-fix_smelly_error_handling_in_kernel_creation
branch
2 times, most recently
from
4866bb1
to
6af3d2c
Compare
fregataa
changed the base branch from
topic/05-23-fix_enhanced_kernel_termination_handling
to
topic/06-26-feature_enable_to_configure_sync_container_lifecycle_task
3 tasks
fregataa
changed the title
fregataa
force-pushed
the
topic/06-26-feature_enable_to_configure_sync_container_lifecycle_task
branch
from
35be346
to
1a75de9
Compare
fregataa
force-pushed
the
topic/06-20-fix_smelly_error_handling_in_kernel_creation
branch
from
6af3d2c
to
37fe73f
Compare
fregataa
force-pushed
the
topic/06-26-feature_enable_to_configure_sync_container_lifecycle_task
branch
from
1a75de9
to
b6d53ae
Compare
fregataa
force-pushed
the
topic/06-20-fix_smelly_error_handling_in_kernel_creation
branch
from
37fe73f
to
0165d2e
Compare
Base automatically changed from
topic/06-26-feature_enable_to_configure_sync_container_lifecycle_task
to
main
July 11, 2024 12:32
fregataa
force-pushed
the
topic/06-20-fix_smelly_error_handling_in_kernel_creation
branch
from
0165d2e
to
566a43c
Compare
Merge activity
|
…2316) ### Fix - Separate the exception context of `container.create()` and `container.start()` to handle them granularly. ### Refactor - Scratch clean codes to `clean_scratch()` **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version
fregataa
force-pushed
the
topic/06-20-fix_smelly_error_handling_in_kernel_creation
branch
from
566a43c
to
e7268d5
Compare
graphite-app
bot
deleted the
topic/06-20-fix_smelly_error_handling_in_kernel_creation
branch
lablup-octodog
pushed a commit
that referenced
this pull request
Jul 11, 2024
…2316) ### Fix - Separate the exception context of `container.create()` and `container.start()` to handle them granularly. ### Refactor - Scratch clean codes to `clean_scratch()` **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2316
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2024
…2316) (#2434) Co-authored-by: fregataa <[email protected]>
jopemachine
pushed a commit
that referenced
this pull request
Jul 14, 2024
…2316) ### Fix - Separate the exception context of `container.create()` and `container.start()` to handle them granularly. ### Refactor - Scratch clean codes to `clean_scratch()` **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
container.create()andcontainer.start()to handle them granularly.Refactor
clean_scratch()Checklist: (if applicable)