Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable to configure sync_container_lifecycles task #2338

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jun 25, 2024

Let's make sync_container_lifecycles() task configurable to turn on/off and set the interval seconds.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added comp:agent Related to Agent component size:S 10~30 LoC labels Jun 25, 2024
Copy link
Member Author

fregataa commented Jun 25, 2024

Copy link

graphite-app bot commented Jun 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fregataa fregataa added this to the 24.03 milestone Jun 25, 2024
@fregataa fregataa force-pushed the topic/05-23-fix_enhanced_kernel_termination_handling branch from 25e70f3 to af994ff Compare July 4, 2024 14:41
@fregataa fregataa force-pushed the topic/06-26-feature_enable_to_configure_sync_container_lifecycle_task branch from 35be346 to 1a75de9 Compare July 4, 2024 14:41
@fregataa fregataa force-pushed the topic/05-23-fix_enhanced_kernel_termination_handling branch 4 times, most recently from 552b746 to 59cbbc9 Compare July 5, 2024 09:56
Base automatically changed from topic/05-23-fix_enhanced_kernel_termination_handling to main July 5, 2024 11:51
@fregataa fregataa force-pushed the topic/06-26-feature_enable_to_configure_sync_container_lifecycle_task branch from 1a75de9 to b6d53ae Compare July 11, 2024 12:11
@fregataa fregataa marked this pull request as ready for review July 11, 2024 12:28
@fregataa fregataa changed the title feature: Enable to configure sync_container_lifecycles task feat: Enable to configure sync_container_lifecycles task Jul 11, 2024
@fregataa fregataa merged commit 2424537 into main Jul 11, 2024
28 of 30 checks passed
@fregataa fregataa deleted the topic/06-26-feature_enable_to_configure_sync_container_lifecycle_task branch July 11, 2024 12:32
lablup-octodog pushed a commit that referenced this pull request Jul 11, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2338
lablup-octodog added a commit that referenced this pull request Jul 11, 2024
Co-authored-by: Sanghun Lee <[email protected]>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant