-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dummy_kernels
table for testing sql_json_merge
#3204
Open
jopemachine
wants to merge
1
commit into
topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_
Choose a base branch
from
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
base: topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
2 tasks
jopemachine
added
the
skip:changelog
Make the action workflow to skip towncrier check
label
Dec 5, 2024
2 tasks
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
December 6, 2024 08:20
ecef6b9
to
a4905e7
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_
branch
from
December 8, 2024 07:09
3056863
to
139b027
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
December 8, 2024 07:09
a4905e7
to
f28038b
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_
branch
from
December 9, 2024 05:23
139b027
to
18906ff
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
3 times, most recently
from
December 9, 2024 05:27
44b11bf
to
d4d43ac
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_
branch
from
December 10, 2024 00:38
656df34
to
dceabcc
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
2 times, most recently
from
December 10, 2024 06:42
b544fc1
to
6327969
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_
branch
from
December 13, 2024 00:58
850165f
to
98c21c0
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
December 13, 2024 00:58
6327969
to
dfe91a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3201.
The previous PR #3201 changed the data structure of
status_history
to a list, and as a result, the test codes forsql_json_merge
that depended onstatus_history
were removed.This PR restores the removed
sql_json_merge
test codes by using thedummy_kernels
table, which retains the previous dict typestatus_history
column.Checklist: (if applicable)