Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dummy_kernels table for testing sql_json_merge #3204

Open
wants to merge 1 commit into
base: topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Dec 5, 2024

Follow-up to #3201.

The previous PR #3201 changed the data structure of status_history to a list, and as a result, the test codes for sql_json_merge that depended on status_history were removed.

This PR restores the removed sql_json_merge test codes by using the dummy_kernels table, which retains the previous dict type status_history column.


Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation

Copy link
Member Author

jopemachine commented Dec 5, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:L 100~500 LoC label Dec 5, 2024
@jopemachine jopemachine added the skip:changelog Make the action workflow to skip towncrier check label Dec 5, 2024
@jopemachine jopemachine added this to the 24.12 milestone Dec 5, 2024
@jopemachine jopemachine marked this pull request as ready for review December 5, 2024 06:11
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from ecef6b9 to a4905e7 Compare December 6, 2024 08:20
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_ branch from 3056863 to 139b027 Compare December 8, 2024 07:09
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from a4905e7 to f28038b Compare December 8, 2024 07:09
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_ branch from 139b027 to 18906ff Compare December 9, 2024 05:23
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch 3 times, most recently from 44b11bf to d4d43ac Compare December 9, 2024 05:27
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_ branch from 656df34 to dceabcc Compare December 10, 2024 00:38
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch 2 times, most recently from b544fc1 to 6327969 Compare December 10, 2024 06:42
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_sessions_kernels_s_status_history_s_type_dict_with_list_ branch from 850165f to 98c21c0 Compare December 13, 2024 00:58
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from 6327969 to dfe91a5 Compare December 13, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant