feat: Replace vfolder's status_history's type dict with list
#3205
+90
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
github-actions
bot
added
comp:manager
2 tasks
2 tasks
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
ecef6b9 to
a4905e7
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
771f2e4 to
314a6e0
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
a4905e7 to
f28038b
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
02f7617 to
b6e059c
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
f28038b to
ee4f67c
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
b6e059c to
8b3fe90
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
ee4f67c to
44b11bf
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
8b3fe90 to
08ea1e7
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
44b11bf to
d4d43ac
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
fb372c7 to
2ad9ea2
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
d4d43ac to
b544fc1
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
2ad9ea2 to
4c0d0c7
Compare
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
b544fc1 to
6327969
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
4c0d0c7 to
d6b288e
Compare
Co-authored-by: octodog <[email protected]>
jopemachine
force-pushed
the
topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
branch
from
6327969 to
dfe91a5
Compare
jopemachine
force-pushed
the
topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_
branch
from
6120bee to
c153753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #767, #3214.
The current implementation saves only the most recent timestamp whenever status information in status_history is updated, and all previous information is deleted.
This PR prevents the loss of timestamp information by changing the data structure of vfolders' status_history to List.
Checklist: (if applicable)