Skip to content

Conversation

@FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Oct 14, 2025

Avoid using generic-array version >0.14.7

Description

gerenic-array 0.14.x has been deprecated in 0.14.8 in favor of 1.x. Since we don't intend to do the bump yet, this PR pins the version to 0.14.x as a workarround.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review October 14, 2025 13:48
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.700 s ±  0.003 s    [User: 23.837 s, System: 0.859 s]
  Range (min … max):   24.698 s … 24.702 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.869 s ±  0.356 s    [User: 24.068 s, System: 0.797 s]
  Range (min … max):   24.616 s … 25.121 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.508 s ±  0.011 s    [User: 23.997 s, System: 0.914 s]
  Range (min … max):   13.501 s … 13.516 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.538 s ±  0.027 s    [User: 24.158 s, System: 0.933 s]
  Range (min … max):   13.519 s … 13.557 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.240 s ±  0.311 s    [User: 36.705 s, System: 1.170 s]
  Range (min … max):   10.020 s … 10.460 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.305 s ±  0.238 s    [User: 36.674 s, System: 1.135 s]
  Range (min … max):   10.137 s … 10.473 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.003 s ±  0.151 s    [User: 37.037 s, System: 1.103 s]
  Range (min … max):    9.896 s … 10.110 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.112 s ±  0.215 s    [User: 36.383 s, System: 1.113 s]
  Range (min … max):    9.960 s … 10.265 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.059 s ±  0.284 s    [User: 37.145 s, System: 1.102 s]
  Range (min … max):    9.858 s … 10.260 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.802 s ±  0.057 s    [User: 37.324 s, System: 1.079 s]
  Range (min … max):    9.762 s …  9.843 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.03 ± 0.03 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.028 s ±  0.017 s    [User: 37.108 s, System: 1.169 s]
  Range (min … max):   10.015 s … 10.040 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.024 s ±  0.037 s    [User: 37.169 s, System: 1.169 s]
  Range (min … max):    9.998 s … 10.050 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 16


@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.100 ± 0.020 2.074 2.132 1.00 ± 0.01
head big_factorial 2.094 ± 0.016 2.069 2.117 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.041 ± 0.014 2.019 2.064 1.01 ± 0.01
head big_fibonacci 2.021 ± 0.018 1.998 2.047 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.293 ± 0.202 7.067 7.671 1.01 ± 0.03
head blake2s_integration_benchmark 7.210 ± 0.095 7.021 7.309 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.156 ± 0.017 2.139 2.187 1.01 ± 0.01
head compare_arrays_200000 2.145 ± 0.025 2.119 2.187 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.433 ± 0.014 1.416 1.464 1.02 ± 0.01
head dict_integration_benchmark 1.409 ± 0.009 1.394 1.420 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.206 ± 0.019 1.187 1.244 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 1.195 ± 0.008 1.185 1.210 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.339 ± 0.094 7.194 7.422 1.00
head integration_builtins 7.372 ± 0.085 7.165 7.462 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.466 ± 0.236 7.244 7.841 1.01 ± 0.03
head keccak_integration_benchmark 7.383 ± 0.079 7.232 7.458 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.163 ± 0.035 2.130 2.248 1.02 ± 0.02
head linear_search 2.124 ± 0.019 2.094 2.155 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.517 ± 0.012 1.499 1.535 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.501 ± 0.014 1.477 1.524 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.466 ± 0.015 1.448 1.497 1.02 ± 0.01
head math_integration_benchmark 1.439 ± 0.013 1.423 1.466 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.220 ± 0.011 1.199 1.239 1.01 ± 0.02
head memory_integration_benchmark 1.207 ± 0.026 1.183 1.270 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.527 ± 0.007 1.520 1.536 1.00
head operations_with_data_structures_benchmarks 1.531 ± 0.019 1.510 1.576 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 529.1 ± 5.4 523.3 539.3 1.01 ± 0.01
head pedersen 525.5 ± 1.9 522.9 529.3 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 617.4 ± 5.3 610.0 624.0 1.01 ± 0.01
head poseidon_integration_benchmark 609.0 ± 4.2 601.3 613.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.768 ± 0.019 1.746 1.810 1.00 ± 0.02
head secp_integration_benchmark 1.767 ± 0.023 1.746 1.830 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 648.6 ± 2.6 644.9 652.2 1.01 ± 0.01
head set_integration_benchmark 643.3 ± 3.3 638.0 647.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.134 ± 0.045 4.081 4.196 1.01 ± 0.01
head uint256_integration_benchmark 4.097 ± 0.035 4.047 4.147 1.00

@FrancoGiachetta FrancoGiachetta changed the title Pin generic-array version to 0.14.7 Pin generic-array version to 0.14.7 or lower Oct 14, 2025
@FrancoGiachetta FrancoGiachetta changed the title Pin generic-array version to 0.14.7 or lower Pin generic-array version to 0.14.x Oct 14, 2025
@FrancoGiachetta FrancoGiachetta force-pushed the pin-generic-array-version branch from a4fc57a to 766c971 Compare October 14, 2025 14:17
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (958ae7e) to head (766c971).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2227   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         104      104           
  Lines       44027    44027           
=======================================
  Hits        42566    42566           
  Misses       1461     1461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Oct 14, 2025
@FrancoGiachetta FrancoGiachetta added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit a3f1ae9 Oct 14, 2025
91 checks passed
@FrancoGiachetta FrancoGiachetta deleted the pin-generic-array-version branch October 14, 2025 18:25
@gabrielbosio gabrielbosio changed the title Pin generic-array version to 0.14.x Avoid using generic-array version >0.14.7 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants