perf(l2): add prover benchmarks from RPC downloaded blocks #1705

xqft · 2025-01-13T20:46:31Z

Motivation

We want to benchmark the L2 prover against rsp, using Ethereum mainnet/testnet blocks. For this we need to fetch state from an Ethereum chain.

Description

adds l2/prover/bench crate
adds basic state fetching functions from the JSON-RPC API

github-actions · 2025-01-13T20:49:21Z

| File                                                                              | Lines | Diff |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/levm/runner/levm_runner.rs           | 390   | -2   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ethrex/ethrex.rs                              | 352   | -2   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/fork_choice.rs                  | 188   | +9   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/payload.rs                      | 480   | -35  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/fork_id.rs                    | 110   | -303 |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/genesis.rs                    | 355   | -6   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/proposer/prover_server.rs               | 459   | +9   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/constants.rs           | 30    | +30  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/lib.rs                 | 2     | +2   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/main.rs                | 47    | +47  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/rpc/asynch.rs          | 189   | +189 |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/rpc/blocking.rs        | 164   | +164 |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/rpc/db.rs              | 126   | +126 |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/bench/src/rpc/mod.rs             | 32    | +32  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/zkvm/interface/risc0/src/main.rs | 44    | +3   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/zkvm/interface/sp1/src/main.rs   | 45    | +3   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/prover/zkvm/interface/src/lib.rs        | 164   | +44  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/utils/test_data_io.rs                   | 92    | +6   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/discv4.rs                   | 905   | -11  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/kademlia.rs                 | 472   | -15  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/net.rs                      | 892   | -246 |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/connection.rs          | 534   | -17  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/eth/backend.rs         | 99    | -9   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/frame.rs               | 205   | +1   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/sync.rs                     | 601   | -6   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/types.rs                    | 147   | -82  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/engine/fork_choice.rs       | 278   | -4   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/eth/client.rs               | 27    | -1   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/engines/api.rs               | 159   | -2   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/engines/in_memory.rs         | 373   | -8   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/engines/libmdbx.rs           | 722   | -9   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/engines/redb.rs              | 670   | -13  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/engines/utils.rs             | 32    | -2   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/storage/store/storage.rs                   | 1152  | -8   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/db.rs                                   | 243   | +146 |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/errors.rs                               | 119   | +4   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/execution_db.rs                         | 129   | -55  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/constants.rs                   | 35    | -14  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/db/mod.rs                      | 58    | -4   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/errors.rs                      | 245   | -2   |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/opcode_handlers/environment.rs | 329   | -11  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/opcode_handlers/system.rs      | 582   | -37  |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/vm.rs                          | 1040  | -235 |
+-----------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/vm.rs                                   | 818   | -1   |
+-----------------------------------------------------------------------------------+-------+------+

Total lines added: +815
Total lines removed: 1140
Total lines changed: 1955

…based approach (#1709) **Motivation** A `ExecutionDB` is created from a block's pre-execution but the current implementation is incorrect and not all needed data gets stored. The goal is to replace this with another approach, using an auxiliary "caching" database that will retrieve data from a `Store` or an RPC endpoint (like in #1705) during the pre-execution of a block, finally resulting in a db that contains all the needed execution data. **Description** - replace `ExecutionDB::from_exec()` to use the `CacheDB`, rename it to `from_store()` - some refactors

xqft added 2 commits January 14, 2025 12:31

add indexdb

94fb3e3

rename InnerIndexDB to AuxIndexDB

2847cf8

xqft mentioned this pull request Jan 14, 2025

fix(l2): replace ExecutionDB from_exec() impl to use a CacheDB based approach #1709

Merged

xqft added 4 commits January 15, 2025 11:06

add IndexDBError

89ba179

change Revm EVM error to ours

f5192c4

replace from_exec impl with indexdb

9616b7d

Merge branch 'main' into l2/touched_state

9d97192

xqft force-pushed the l2/rpc_bench branch from eb514ad to 98bab67 Compare January 15, 2025 20:46

xqft changed the base branch from main to l2/touched_state January 15, 2025 20:46

xqft added 17 commits January 17, 2025 11:39

WIP add PreExecDB

253ab7f

WIP add proofs in from_store()

966706e

WIP remove internal mutability

2135a08

refactor

eabd6a3

replace PreExecDB with CacheDB

9ffbc44

nits

a308649

fix filter

b0d214f

add nonce and balance validations during pre-exec

1b64809

put proofs inside executiondb

dd75353

fix errors

389ddab

remove optiona_balance_check feature

fec82ef

remove unused errors

0405835

fix filter

987e359

add db verification

4a0a715

remove unused imports

eb98e53

update sp1 prover

892060a

Merge branch 'main' into l2/touched_state

d9aee43

xqft force-pushed the l2/rpc_bench branch from 98bab67 to c756be3 Compare January 20, 2025 20:56

xqft mentioned this pull request Jan 21, 2025

perf(l2): rpc comparison bench #1360

Closed

remove revm types

6f2169c

add bench crate

d0669bf

xqft force-pushed the l2/rpc_bench branch from c756be3 to d0669bf Compare January 21, 2025 19:09

xqft added 8 commits January 21, 2025 18:39

make a blocking rpc client

321d260

create ToExecDB trait

76c5cff

remove unnecessary store_wrapper

fdf6d9f

WIP optimizing rpc db

297b7f4

cache storage

6a7c60c

add timeout and retry

c18e753

update cargo lock

e5f9876

remove blocking rpc

b8c953e

Base automatically changed from l2/touched_state to main January 24, 2025 14:39

xqft added 5 commits January 24, 2025 12:01

refactor rpc

f84063e

add storageAt request

664804d

fix access list

de11b0a

fetch latest block number

90d71a4

reqwest optimizations

99938c0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(l2): add prover benchmarks from RPC downloaded blocks #1705

perf(l2): add prover benchmarks from RPC downloaded blocks #1705

xqft commented Jan 13, 2025

github-actions bot commented Jan 13, 2025 •

edited

Loading

perf(l2): add prover benchmarks from RPC downloaded blocks #1705

Are you sure you want to change the base?

perf(l2): add prover benchmarks from RPC downloaded blocks #1705

Conversation

xqft commented Jan 13, 2025

github-actions bot commented Jan 13, 2025 • edited Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading