Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validium support external node (Moved) #184

Open
wants to merge 4 commits into
base: feat_validium_pubdata_abstraction
Choose a base branch
from

Conversation

toni-calvin
Copy link

@toni-calvin toni-calvin commented Feb 23, 2024

Closes #167

Summary

  1. This pull request addresses the need to dynamically set the L1CommitGeneratorMode of the external node based on the configuration value l1_batch_commit_data_generator_mode in the etc/env/ext-node.toml file. If the configuration value is set, the external node will be configured for Validium; otherwise, the default mode will be Rollup.

Changes Made

  1. Added logic to check for the presence of l1_batch_commit_data_generator_mode in etc/env/ext-node.toml.
  2. If the value is set, the L1CommitGeneratorMode of the external node is set to "validium."
  3. If the value is not set, the default mode "rollup" is used.
  4. Users can manually update the configuration by adding l1_batch_commit_data_generator_mode="Validium" to the ext-node.toml file.

@toni-calvin toni-calvin changed the title Feat add validium support external node feat: add validium support external node Feb 23, 2024
@ilitteri ilitteri linked an issue Feb 23, 2024 that may be closed by this pull request
@lferrigno lferrigno changed the title feat: add validium support external node feat: add validium support external node (Moved) Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for External Node
2 participants