-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM Simulator Flag #244
EVM Simulator Flag #244
Conversation
UseEvmSimulator::from_env().expect("USE EVM SIMULATOR FLAG SHOULD BE SET"); | ||
if !use_evm_simulator.use_evm_simulator { | ||
evm_simulator_bytecode = vec![]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
let evm_simulator_bytecode = if UseEvmSimulator::from_env().expect("USE EVM SIMULATOR FLAG SHOULD BE SET").use_evm_simulator {
read_sys_contract_bytecode("", "EvmInterpreter", ContractLanguage::Yul)
} else {
vec![]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not possible, because then we need to calculate the hash of that bytecode, if we try to calculate the hash of an empty bytecode it gives an error when running zk init
:
Invalid bytecode: ()
We need to still have the hash of the actual interpreter bytecode, and then setting that bytecode to an empty vector.
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
What ❔
This PR adds a flag for enabling the evm interpreter, it can be found on
etc/env/base/use_evm_simulator.toml
Why ❔
Checklist
zk fmt
andzk lint
.