Support AWS-SDK since 3.286.2 breaking changes #49664
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Version 3.286.2 of aws-sdk-php changes the way QueueUrl is handled after switching SQS Client to the Json protocol.
https://github.com/aws/aws-sdk-php/releases/tag/3.286.2
This works fine if you're actually using an SQS queue-name only, but if you're using a different full URL for local (i.e. elasticmq) it forcibly attempts to hit the default AWS SQS url instead.
Also the versions 3 -> 3.288.1 are affected by the following security warning:
Therefore I've updated the composer json to require the latest safe release from aws-sdk-php
Thoughts before submitting for review
The way I've done it will more than likely break it for people that aren't using the full URL.
Ideally we would: