Skip to content

Support AWS-SDK since 3.286.2 breaking changes #49664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support AWS-SDK since 3.286.2 breaking changes #49664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ccdac1
[10.x] Update aws-sdk-php to secure version
danielsimkus Jan 12, 2024
92b3e76
[10.x] Replace QueueUrl with Endpoint
danielsimkus Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"require-dev": {
"ext-gmp": "*",
"ably/ably-php": "^1.0",
"aws/aws-sdk-php": "^3.235.5",
"aws/aws-sdk-php": "3.288.1",
"doctrine/dbal": "^3.5.1",
"fakerphp/faker": "^1.21",
"guzzlehttp/guzzle": "^7.5",
Expand Down
4 changes: 2 additions & 2 deletions src/Illuminate/Queue/Jobs/SqsJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function release($delay = 0)
parent::release($delay);

$this->sqs->changeMessageVisibility([
'QueueUrl' => $this->queue,
'Endpoint' => $this->queue,
'ReceiptHandle' => $this->job['ReceiptHandle'],
'VisibilityTimeout' => $delay,
]);
Expand All @@ -68,7 +68,7 @@ public function delete()
parent::delete();

$this->sqs->deleteMessage([
'QueueUrl' => $this->queue, 'ReceiptHandle' => $this->job['ReceiptHandle'],
'Endpoint' => $this->queue, 'ReceiptHandle' => $this->job['ReceiptHandle'],
]);
}

Expand Down
10 changes: 5 additions & 5 deletions src/Illuminate/Queue/SqsQueue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function __construct(SqsClient $sqs,
public function size($queue = null)
{
$response = $this->sqs->getQueueAttributes([
'QueueUrl' => $this->getQueue($queue),
'Endpoint' => $this->getQueue($queue),
'AttributeNames' => ['ApproximateNumberOfMessages'],
]);

Expand Down Expand Up @@ -111,7 +111,7 @@ function ($payload, $queue) {
public function pushRaw($payload, $queue = null, array $options = [])
{
return $this->sqs->sendMessage([
'QueueUrl' => $this->getQueue($queue), 'MessageBody' => $payload,
'Endpoint' => $this->getQueue($queue), 'MessageBody' => $payload,
])->get('MessageId');
}

Expand All @@ -133,7 +133,7 @@ public function later($delay, $job, $data = '', $queue = null)
$delay,
function ($payload, $queue, $delay) {
return $this->sqs->sendMessage([
'QueueUrl' => $this->getQueue($queue),
'Endpoint' => $this->getQueue($queue),
'MessageBody' => $payload,
'DelaySeconds' => $this->secondsUntil($delay),
])->get('MessageId');
Expand Down Expand Up @@ -169,7 +169,7 @@ public function bulk($jobs, $data = '', $queue = null)
public function pop($queue = null)
{
$response = $this->sqs->receiveMessage([
'QueueUrl' => $queue = $this->getQueue($queue),
'Endpoint' => $queue = $this->getQueue($queue),
'AttributeNames' => ['ApproximateReceiveCount'],
]);

Expand All @@ -191,7 +191,7 @@ public function clear($queue)
{
return tap($this->size($queue), function () use ($queue) {
$this->sqs->purgeQueue([
'QueueUrl' => $this->getQueue($queue),
'Endpoint' => $this->getQueue($queue),
]);
});
}
Expand Down