Reduce failure rate of Arr::shuffle() tests #49769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, shuffling a 26 character string only has a chance of 1/(26!) ~ 4*10^(-26) of returning the original order. This alone is sufficiently unlikely to happen in practice 🙂 |
|
I thought that'd be the case, but figured I'd go the paranoid route. Thanks for confirming the fix! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully) fixes the false positive failure rate on the
Arr::shuffle()tests introduced in #49642, as per @TimWolla's comments.I've increase the data set to 26 characters (
A-Z), and changed it to runshuffle()twice in the assertions. This should significantly lower the false positive failure, as the chance of the same shuffle being produced is significantly lower.I also split the test two into, so they can fail independently.