Skip to content

Reduce failure rate of Arr::shuffle() tests #49769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Reduce failure rate of Arr::shuffle() tests #49769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions tests/Support/SupportArrTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,24 +907,34 @@ public function testSet()
$this->assertEquals([1 => 'hAz'], Arr::set($array, 1, 'hAz'));
}

public function testShuffle()
public function testShuffleProducesDifferentShuffles()
{
$input = ['a', 'b', 'c', 'd', 'e', 'f'];
$input = range('a', 'z');

$this->assertNotEquals(
$input,
Arr::shuffle($input)
$this->assertFalse(
Arr::shuffle($input) === Arr::shuffle($input) && Arr::shuffle($input) === Arr::shuffle($input),
"The shuffles produced the same output each time, which shouldn't happen."
);
}

public function testShuffleActuallyShuffles()
{
$input = range('a', 'z');

$this->assertFalse(
Arr::shuffle($input) === Arr::shuffle($input) && Arr::shuffle($input) === Arr::shuffle($input),
"The shuffles produced the same output each time, which shouldn't happen."
);

$this->assertNotEquals(
Arr::shuffle($input),
Arr::shuffle($input)
$this->assertFalse(
Arr::shuffle($input) === $input && Arr::shuffle($input) === $input,
"The shuffles were unshuffled each time, which shouldn't happen."
);
}

public function testShuffleKeepsSameValues()
{
$input = ['a', 'b', 'c', 'd', 'e', 'f'];
$input = range('a', 'z');
$shuffled = Arr::shuffle($input);
sort($shuffled);

Expand Down