-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Supports PHP 8.4 #304
base: main
Are you sure you want to change the base?
Conversation
Hey @crynobone there are deprecations in the PHP 8.4 Unit Tests when running This is probably due to using Laravel Zero v10 and illuminate/view v10 instead of v11. |
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone this should be fine to merge? |
@mokhosh I think this is pending the next release of illuminate/xxx 10.48.5 (so probably Tuesday) |
@crynobone I am not sure if Laravel Pint can fully support PHP 8.4 for now. PHP-CS-Fixer has not full PHP 8.4 support. A corresponding, PR is WIP: PHP-CS-Fixer/PHP-CS-Fixer#8300 You currently can only run PHP-CS-Fixer with the following env flag enabled: PHP_CS_FIXER_IGNORE_ENV=1 vendor/bin/php-cs-fixer fix (I think Pint runs, even though this flag is not set, I did not test this.) |
Yes, you can run Fixer on any PHP version using |
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone in my opinion the way going forward should be:
And then later when PHP-CS-Fixer is PHP 8.4 compatible according to the milestone. There should be another PR, which updates to the latest PHP-CS-Fixer version and only show the warning for PHP 8.5 |
illuminate/support
: [10.x] PHP 8.4 Code Compatibility framework#53612friendsofphp/php-cs-fixer
: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/milestone/173`laravel-zero/foundation
: Sync changes fromilluminate/foundation
via SyncIlluminate\Foundation
from Laravel Framework 10.48.25 laravel-zero/foundation#104nunomaduro/termwind
nunomaduro/collision
composer.json
andcomposer.lock
was updated using: