Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid paths #1478

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

ahmedash95
Copy link
Contributor

Why?

While removing a directory that is parked in Valet. I encountered an error originating from Herd's Valet, though the issue lies with Valet itself. And from a user's perspective, I believe Valet should remain operational even if one of the paths is invalid

image

Suggestion

Introducing a command such as valet check would be beneficial. It could report on Valet's status, confirming if all paths are correct or if any path is invalid.

@drbyte
Copy link
Contributor

drbyte commented Apr 1, 2024

I agree with this code change.

For cleanup, perhaps the valet paths command could offer to cleanup any invalid paths when it displays the ones it has registered. I'd support a PR or discussion for implementing that.

@driesvints driesvints merged commit 0f3ab1f into laravel:master May 7, 2024
6 checks passed
@driesvints
Copy link
Member

Thanks!

@ahmedash95 ahmedash95 deleted the fix-invalid-paths branch May 7, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants