Resolve merge conflicts in (Pass the language code to iTunes search api to get localized release notes) PR #439
Conversation
…search Pass the language code to iTunes search api to get localized release notes
…search Fix tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 13 13
Lines 1221 1221
=======================================
Hits 1105 1105
Misses 116 116 ☔ View full report in Codecov by Sentry. |
|
resolve merge conflicts from PR #351 |
|
This PR seems similar to #443. |
This PR fixes the merge conflicts in that PR, and passes all tests |
lib/src/itunes_search_api.dart
Outdated
| assert(bundleId.isNotEmpty); | ||
| if (bundleId.isEmpty) { | ||
| return null; | ||
| } | ||
|
|
||
| final url = lookupURLByBundleId(bundleId, | ||
| country: country ?? '', useCacheBuster: useCacheBuster)!; | ||
| country: country ??= '', language: language ?? '', useCacheBuster: |
There was a problem hiding this comment.
@ibraheemalayan There seems to be an extra character added to this existing code country: country ??= ''. The = was added. Was there a reason for thiat?
There was a problem hiding this comment.
Looks like it is a mistake but it doesn't affect the code.
There was a problem hiding this comment.
I can merge this after that extra character is removed.
There was a problem hiding this comment.
I did the change
|
Is the test that failed related ? |
@ibraheemalayan It was not a test that failed, it was |
|
@ibraheemalayan Do you have Flutter 3.24.0+ on your local machine? If not, I can fix this issue. |
I will fit it here. Thanks for the PR 👍 |
|
These updates were published on pub.dev as version 11.1.0: https://pub.dev/packages/upgrader/versions/11.1.0 |
No description provided.