Pass the language code to iTunes search api to get localized release notes #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryaasen
reviewed
Sep 4, 2024
| @@ -239,6 +239,37 @@ class Upgrader with WidgetsBindingObserver { | |||
| state.countryCodeOverride ?? findCountryCode(locale: locale); | |||
| if (state.debugLogging) { | |||
| print('upgrader: countryCode: $country'); | |||
| // The language code of the locale, defaulting to `en`. | |||
There was a problem hiding this comment.
This code looks old and is already in the master branch. Can you check your PR merge point to see that it points to the latest code.
There was a problem hiding this comment.
This code looks old and is already in the master branch. Can you check your PR merge point to see that it points to the latest code.
Sorry @larryaasen I would be very happy to fix the merge conflicts but since I am not working on the project that uses this package I will need more time to check how the code is working and that my changes are working well and I am little bit busy these days with another projects so look in to the other similar PRs.
|
This PR seems similar to #439. |
|
Fixed in #439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #314