Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable citation links #1368

Merged
merged 9 commits into from
Jul 17, 2023
Merged

Editable citation links #1368

merged 9 commits into from
Jul 17, 2023

Conversation

longhotsummer
Copy link
Contributor

@longhotsummer longhotsummer commented Jul 10, 2023

Functionality to make it possible to edit citation link extractions used for PDFs. Ref #1317

  • use the existing (but not used) /api/citation-links/ API
  • add necessary fields to the citation link serializer (document, id)
  • add gutter items for citation links in edit mode
  • PDFCitationLinks is now a IGutterEnrichmentProvider so it can participate when the user highlights text in the PDF view
  • change CitationLink.url to a plain char field, since we must allow /akn/... as a link, not just a fully-qualified URL.

https://www.loom.com/share/0a30b5d90abe4463af2117c42f11cfad

@longhotsummer longhotsummer merged commit 7cfc7b5 into main Jul 17, 2023
9 checks passed
@longhotsummer longhotsummer deleted the editable-citation-links branch July 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant