Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feng Bash Scripts and Slurm Scripts for NERSC #2

Merged
merged 18 commits into from
Mar 13, 2024

Conversation

smallfishabc
Copy link
Collaborator

Motivation

To prepare the training dataset, PDBs may need to be downloaded/processed from the existing dataset.

CoDNaS folder stores bash scripts to automatically obtain PDBs and calculate P(r) for different conformations of the same protein.

PDB70_NERSC folder stores slrum, bash and python scripts to clean downloaded PDB70 dataset and generate P(r) curve with NERSC.

How to test the behavior?

There is a REAME file in the CoDNaS folder to explain the usage of the scripts.

The slurm file in the PDB70_NERSC folder can be submitted to NERSC with SLURM command sbatch to run the script. 

We need to download and copy all scripts in PDB70_NERSC folder to the root directory of PDB70 database together with PDBs. 

We then need to mkdir for pdb/saxs_r/sequence under the root directory and then submit the job.

Checklist

We may need to combine the Python file under the PDB70_NERSC folder as a function of the metfish package.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@48207de). Click here to learn what that means.

Files Patch % Lines
src/metfish/utils.py 27.27% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   80.95%           
=======================================
  Files           ?        2           
  Lines           ?       63           
  Branches        ?        0           
=======================================
  Hits            ?       51           
  Misses          ?       12           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallfishabc smallfishabc requested a review from ajtritt January 25, 2024 19:51
Copy link
Contributor

@ajtritt ajtritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename Feng_bash_scripts to something more descriptive, and then move it and PDB70_NERSC into a new directory title scripts.

PDB70_NERSC/PDBtoSeq.py Outdated Show resolved Hide resolved
PDB70_NERSC/parallel_PDB70.slurm Outdated Show resolved Hide resolved
@smallfishabc
Copy link
Collaborator Author

Hi, the slurm and python scripts are ready to review.
The processed training/testing dataset is stored at /global/cfs/cdirs/m3513/metfish/PDB70_verB_fixed_data with a detailed readme file.
I will continue the data transfer from my scratch to this folder after the NERSC maintenance.

@smallfishabc smallfishabc merged commit aab0700 into main Mar 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants