Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test modification of intermediate structural representations #3

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

stephprince
Copy link
Collaborator

@stephprince stephprince commented Feb 14, 2024

Motivation

These changes add analysis scripts and methods to test how alphafold outputs change when manipulating the intermediate structural representations during the recycling process.

See related PR changes in lbl-cbg/alphafold#1 and lbl-cbg/ColabFold#1 to run.

How to test the behavior?

  1. Pull related PRs from lbl-cbg ColabFold/alphafold repos.
  2. Add conformer pair data to metfish/data folder.
  3. Run preprocess_conformer_pairs.py to generate pdb, fasta, and pickle files to use as inputs to AF.
  4. Run colabfold_batch with the following arguments to modify the intermediate structural representations.
colabfold_batch --save-all --save-recycles --num-recycle=5 --modification_method="replace_structure" ${INPUT} ${OUTPUT_DIR}
  1. Visualize results using the scripts/plot_conformer_pair_outcomes.ipynb notebook

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 23.59551% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 46.62%. Comparing base (aab0700) to head (3a64fa6).

Files Patch % Lines
src/metfish/utils.py 23.59% 68 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
- Coverage   80.95%   46.62%   -34.34%     
===========================================
  Files           2        2               
  Lines          63      148       +85     
===========================================
+ Hits           51       69       +18     
- Misses         12       79       +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallfishabc
Copy link
Collaborator

I think we should use SeqIO in the BioPython to extract sequences. And I think we should avoid using Biopandas if BioPython can do the job to keep the simplicity of the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants