Issue2885 fan coil unit controls #3627
Conversation
Merge lbl master into pnnl master
…uildings:issue1913_g36_final
Issue2885 fan coil unit controls
…sts. Updated parameter group annotations. Simplified logic with hysteresis blocks
…ontrols Issue2885 fan coil unit controls
|
@mwetter It's ready for your review after the CI tests passed. |
There was a problem hiding this comment.
Revert this formatting only change.
There was a problem hiding this comment.
Revert this formatting only change which I think is unintentional.
| or heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.Electric)); | ||
|
|
||
| parameter Real cooDea( | ||
| unit="1", |
There was a problem hiding this comment.
Units should be made final as the model is only valid for these units.
There was a problem hiding this comment.
This controller is not used in any closed loop test. We need to have a closed loop test before merging. Experience shows that often bugs or unsuitable I/O are discovered when a controller is connected to an equipment model.
There was a problem hiding this comment.
Simulating simulateModel("Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Validation.Controller_UnspecifiedClimate", method="Cvode", stopTime=3600, tolerance=1e-06, resultFile="MultizoneController");
gives warnings about unspecified climate that need to be corrected.
| "Time period for which hotWatResReqLim3 has to be exceeded before three hot water reset requests are sent" | ||
| annotation(Dialog(tab="Request limits", group="Hot water reset requests", enable=have_hotWatCoi)); | ||
|
|
||
| parameter Real Thys( |
There was a problem hiding this comment.
Shouldn't this be THys (Note that Thys is used in many models).
| This example validates | ||
| <a href=\"modelica://Buildings.Controls.OBC.ASHRAE.G36.FanCoilUnit.Controller\"> | ||
| Buildings.Controls.OBC.ASHRAE.G36.FanCoilUnit.Controller</a>. | ||
| <br> |
There was a problem hiding this comment.
Use
</p>
<p>
to separate paragraphs rather than <br>
|
@karthikeyad-pnnl Would you please address Michael's inline comments? |
|
@karthikeyad-pnnl Let me know if you need help on addressing the comments. |
|
@JayHuLBL Thanks for checking in! We are currently working on the closed loop validation, so we can temporarily deprioritize this |
|
@karthikeyad-pnnl Is there any update on this PR? |
This closes #2885.