Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2885 fan coil unit controls #3627

Open
wants to merge 115 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 107 commits
Commits
Show all changes
115 commits
Select commit Hold shift + click to select a range
a432926
Merge pull request #20 from lbl-srg/master
karthikeyad-pnnl Sep 1, 2020
3b2b6ca
Merge remote-tracking branch 'upstream/master'
karthikeyad-pnnl Jun 7, 2021
7f9c083
Merge remote-tracking branch 'upstream/master'
karthikeyad-pnnl Sep 15, 2021
b8b08fe
Merge remote-tracking branch 'upstream_local/master'
karthikeyad-pnnl Oct 6, 2021
53454bf
Merge branch 'lbl-srg:master' into master
karthikeyad-pnnl Oct 25, 2021
45d798b
Merge branch 'lbl-srg:master' into master
karthikeyad-pnnl Nov 9, 2021
ec99cc6
Merge branch 'lbl-srg:master' into master
karthikeyad-pnnl Jan 26, 2022
b5ae2ff
Merge branch 'lbl-srg:master' into master
karthikeyad-pnnl Feb 14, 2022
0709671
Added packages for fan coil unit control sequences
karthikeyad-pnnl Feb 15, 2022
2fd6809
Backing up files
karthikeyad-pnnl Mar 8, 2022
d680a40
Backing up files
karthikeyad-pnnl Mar 15, 2022
0eb59d0
Updated formatting
karthikeyad-pnnl Mar 17, 2022
d14ded5
Added documentation sections and updated formatting
karthikeyad-pnnl Mar 19, 2022
f7aae21
Updated documentation and validation model for main controller
karthikeyad-pnnl Mar 22, 2022
9e1c512
Added control logic diagrams to information sections
karthikeyad-pnnl Mar 27, 2022
aced90f
Updated package.order files
karthikeyad-pnnl Mar 27, 2022
242f261
Added simulation settings to validation models
karthikeyad-pnnl Mar 28, 2022
3636340
Fixed newlines at end of mos file
karthikeyad-pnnl Mar 30, 2022
b573ce1
Adding unit test results for main FCU controller
karthikeyad-pnnl Mar 31, 2022
60c97db
Removed example icon file extension from Modelica Standard Library
karthikeyad-pnnl Mar 31, 2022
d344a80
Added unit test results for subsequences
karthikeyad-pnnl Mar 31, 2022
ec27366
Updated file spacing
karthikeyad-pnnl Mar 31, 2022
477025d
Updated stop time in validation model settings to correspond to stop …
karthikeyad-pnnl Apr 4, 2022
2732a20
Updated models based on feedback during presentation
karthikeyad-pnnl Apr 15, 2022
6d090a6
Removed redubndant pre blocks
karthikeyad-pnnl Apr 15, 2022
bd59301
Added model for plant requests from G36 package on lbl-srg/modelica-b…
karthikeyad-pnnl Apr 30, 2022
aea0310
Added request generation block to fan coil unit controls package
karthikeyad-pnnl May 3, 2022
188e5b7
Updated controller with plant request module
karthikeyad-pnnl May 7, 2022
cb7e9eb
Updated formatting
karthikeyad-pnnl May 7, 2022
d4ac322
Updated unit test results
karthikeyad-pnnl May 9, 2022
3a6d90b
Updated package order files
karthikeyad-pnnl May 9, 2022
bb39593
Removed unused files for G36 single-zone AHU plant requests
karthikeyad-pnnl May 9, 2022
f842463
Merge remote-tracking branch 'upstream/issue2885_FanCoilUnitControls'…
karthikeyad-pnnl Sep 12, 2022
8921f6a
Updated have_coolingCoil to have_cooCoi
karthikeyad-pnnl Sep 12, 2022
6d6176e
Fixed validation models with have_cooCoi
karthikeyad-pnnl Sep 12, 2022
ee6f300
Replaced user-defined parameter for have_heatingCoil with two paramet…
karthikeyad-pnnl Sep 12, 2022
9362122
Updated parameter comments
karthikeyad-pnnl Sep 12, 2022
1eeb084
Addeed information sections to packages. Removed non-required paramet…
karthikeyad-pnnl Sep 13, 2022
58c41f2
Added protected statement to reduce output variables in results file
karthikeyad-pnnl Sep 13, 2022
11cc01e
Updated text display settings for all control blocks
karthikeyad-pnnl Sep 13, 2022
a95e635
Merge branch 'issue2885_FanCoilUnitControls' into modelica-buildings/…
terrancelu92 Nov 16, 2022
9fc8535
Renamed the parameter heaSpeMin, heaSpeMax to heaSpe_min, heaSpe_max
terrancelu92 Nov 16, 2022
2c7d8ea
Renamed the group name parameters
terrancelu92 Nov 16, 2022
8a355ba
Renamed the comments of the heaDea
terrancelu92 Nov 16, 2022
8ab9778
Changed the instance name isOcc to notUno.
terrancelu92 Nov 16, 2022
fcbbb7c
Changed surfix _min, _max to lower cases
terrancelu92 Nov 16, 2022
3362fa6
Changed the parameter name heaPerMin, heaPerMax to uHea_min, uHea_max…
terrancelu92 Nov 16, 2022
4c101af
Changed the variable name in the intro figure
terrancelu92 Nov 17, 2022
34ae94a
Changed the min/max parameter names
terrancelu92 Nov 17, 2022
792e189
Add spaces in the info
terrancelu92 Nov 17, 2022
9a01585
Changed the naming from TZonSetHea to TZonHeaSet
terrancelu92 Nov 17, 2022
e762a9e
Changed the naming from TZonSetHea to TZonHeaSet in the example file
terrancelu92 Nov 17, 2022
5b4fffe
Changed the name of cooPerMax/heaPerMax to uCoo_max/uHea_max
terrancelu92 Nov 17, 2022
097a782
Change the naming of min/max parameters
terrancelu92 Nov 17, 2022
d3ddb2b
Correct the documentation error
terrancelu92 Nov 17, 2022
8b30c8c
Translate the variable name to detailed value
terrancelu92 Nov 17, 2022
35902ae
Update SupplyAirTemperature.png
terrancelu92 Nov 17, 2022
e74839d
Merge remote-tracking branch 'upstream/issue2885_FanCoilUnitControls'…
karthikeyad-pnnl Nov 21, 2022
ca54aac
Merge remote-tracking branch 'upstream/master' into issue2885_FanCoil…
karthikeyad-pnnl Nov 21, 2022
f6fa1bc
Merge branch 'master' into issue2885_FanCoilUnitControls
terrancelu92 Nov 21, 2022
dba6ea8
Merge branch 'issue2885_FanCoilUnitControls' of github.com:terrancelu…
karthikeyad-pnnl Nov 21, 2022
ab5f460
Merge branch 'terrancelu92-issue2885_FanCoilUnitControls' into issue2…
karthikeyad-pnnl Nov 21, 2022
534d3c5
Updated instance names for min and max parameters. Added input interf…
karthikeyad-pnnl Nov 28, 2022
f6540ab
Updated instance names in validation scripts. Removed non-required ze…
karthikeyad-pnnl Nov 28, 2022
7edd0e7
Updated unit test results
karthikeyad-pnnl Nov 28, 2022
08b449f
Changed annotation and comments for parameters
karthikeyad-pnnl Nov 30, 2022
285ab15
Updated fan speed logic to switch to deadband speed once the fan is e…
karthikeyad-pnnl Nov 30, 2022
9c2cc04
Updated unit test results
karthikeyad-pnnl Nov 30, 2022
41aa8cb
Updated text in documentation sections
karthikeyad-pnnl Nov 30, 2022
8273a1c
Updated interface instance names
karthikeyad-pnnl Nov 30, 2022
3212320
Updated unit test results
karthikeyad-pnnl Nov 30, 2022
fdee3c4
Updated documentation and images so that parameter names match across…
karthikeyad-pnnl Nov 30, 2022
c40af7d
Updated names and comments of connections in FanCoilUnit folder
junkewang001 Oct 4, 2023
8b45252
Merge pull request #96 from junkewang001/issue2885_FanCoilUnitControls
karthikeyad-pnnl Oct 12, 2023
d6631b0
Updated names of the connections in validation models
junkewang001 Oct 12, 2023
1d3ac0e
Merge pull request #100 from junkewang001/issue2885_FanCoilUnitControls
karthikeyad-pnnl Oct 12, 2023
7470e82
Propagated the naming changes to the validation scripts
junkewang001 Oct 12, 2023
f03e16c
Merge pull request #101 from junkewang001/issue2885_FanCoilUnitControls
karthikeyad-pnnl Oct 12, 2023
0d0bb42
Updated unit test logs
junkewang001 Oct 12, 2023
4cbc0f2
Merge pull request #102 from junkewang001/issue2885_FanCoilUnitControls
karthikeyad-pnnl Oct 16, 2023
982fdb9
Updated interface names in the documentation sections. Added addition…
karthikeyad-pnnl Oct 17, 2023
16f5c4b
Merge pull request #2946 from karthikeyad-pnnl/issue2885_FanCoilUnitC…
JayHuLBL Jan 3, 2024
1b8f91f
Merge branch 'master' into issue2885_FanCoilUnitControls
JayHuLBL Jan 3, 2024
d9b30bf
merged master, improved implementation
JayHuLBL Jan 4, 2024
9dcbd7d
removed empty lines
JayHuLBL Jan 5, 2024
bb7b4de
improved comment
JayHuLBL Jan 5, 2024
80101ff
added enabling conditions
JayHuLBL Jan 5, 2024
7da157c
merged master
JayHuLBL Jan 9, 2024
cf53ad1
Merge branch 'master' into issue2885_FanCoilUnitControls
JayHuLBL Mar 1, 2024
7986025
Updated documentation for main controller with plant request information
karthikeyad-pnnl Apr 8, 2024
1046724
Merge pull request #3785 from karthikeyad-pnnl/issue2885_FanCoilUnitC…
JayHuLBL Apr 8, 2024
200a174
Merge branch 'master' into issue2885_FanCoilUnitControls
JayHuLBL Apr 8, 2024
48c213f
Merge branch 'issue2885_FanCoilUnitControls' of https://github.com/lb…
JayHuLBL Apr 8, 2024
51577e5
merged master
JayHuLBL Apr 10, 2024
d7a6ac1
merged master
JayHuLBL Apr 12, 2024
09c6df1
Merge pull request #134 from lbl-srg/issue2885_FanCoilUnitControls
karthikeyad-pnnl May 2, 2024
8062283
Added additional parameter for symmetry between plant and reset reque…
karthikeyad-pnnl May 3, 2024
93a5b3b
Added CDL flags to annotations in main controller and submodules
karthikeyad-pnnl May 3, 2024
44b8796
Changed validation model settings to change window open status
karthikeyad-pnnl Aug 15, 2024
245aaf8
Changed window status to open for one instance
karthikeyad-pnnl Aug 15, 2024
7323a47
Updated unit test results
karthikeyad-pnnl Aug 15, 2024
0bdcaf5
Updated incorrect comment on controller instance
karthikeyad-pnnl Aug 15, 2024
64da409
Merge pull request #3960 from karthikeyad-pnnl/issue2885_FanCoilUnitC…
JayHuLBL Aug 22, 2024
8afcba3
merged master
JayHuLBL Aug 22, 2024
5a7c2ea
improved temperature settings
JayHuLBL Aug 22, 2024
ddb53d3
updated checksum
JayHuLBL Aug 22, 2024
c50ec2d
Removed connection to itself
mwetter Aug 23, 2024
bbacefd
Moved layout
mwetter Aug 23, 2024
ab33de9
Reformatted file
mwetter Aug 23, 2024
71f6d70
Revised info section
mwetter Aug 23, 2024
b477ace
Revised info section
mwetter Aug 23, 2024
4ee7c98
removed self connection [ci skip]
JayHuLBL Aug 27, 2024
b5b1f9b
merged master
JayHuLBL Dec 18, 2024
b02e46b
updated release note
JayHuLBL Dec 18, 2024
0969c25
reverted changes
JayHuLBL Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this formatting only change.

Original file line number Diff line number Diff line change
Expand Up @@ -962,8 +962,7 @@ block Controller "Multizone VAV air handling unit controller"
annotation (Placement(transformation(extent={{-220,500},{-200,520}})));
Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.SetPoints.SupplySignals supSig(
final have_heaCoi=heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.WaterBased or heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.Electric,
final have_cooCoi=cooCoi == Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased
or cooCoi == Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.DXCoil,
final have_cooCoi=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased or cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.DXCoil,
final controllerType=valCon,
final kTSup=kVal,
final TiTSup=TiVal,
Expand Down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this formatting only change which I think is unintentional.

Original file line number Diff line number Diff line change
Expand Up @@ -377,12 +377,12 @@ block Controller
Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Economizers.Subsequences.Modulations.ReturnFan
modRet(
final have_dirCon=buiPreCon == Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReturnFanDp,

final uMin=uHeaMax,
final uMax=uCooMin) if (buiPreCon == Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReturnFanMeasuredAir
or buiPreCon == Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReturnFanDp)
"Modulate economizer dampers position for buildings with return fan controlling pressure"
annotation (Placement(transformation(extent={{100,20},{120,40}})));

Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Economizers.Subsequences.Modulations.Reliefs modRel(
final uMin=uHeaMax,
final uMax=uCooMin,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,21 @@ model Controller_Disable
Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Economizers.Controller
eco(
final minOADes=Buildings.Controls.OBC.ASHRAE.G36.Types.OutdoorAirSection.SingleDamper,

final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReliefDamper,

final eneStd=Buildings.Controls.OBC.ASHRAE.G36.Types.EnergyStandard.ASHRAE90_1,

final ecoHigLimCon=Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedDryBulb,

final ashCliZon=Buildings.Controls.OBC.ASHRAE.G36.Types.ASHRAEClimateZone.Zone_1A,

final minOAConTyp=Buildings.Controls.OBC.CDL.Types.SimpleController.PI)
"Multi zone VAV AHU economizer "
annotation (Placement(transformation(extent={{20,0},{40,40}})));

Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Economizers.Controller
eco1(
final minOADes=Buildings.Controls.OBC.ASHRAE.G36.Types.OutdoorAirSection.SingleDamper,

final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReliefDamper,

final eneStd=Buildings.Controls.OBC.ASHRAE.G36.Types.EnergyStandard.ASHRAE90_1,

final ecoHigLimCon=Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedEnthalpyWithFixedDryBulb,

final ashCliZon=Buildings.Controls.OBC.ASHRAE.G36.Types.ASHRAEClimateZone.Zone_1A,

final minOAConTyp=Buildings.Controls.OBC.CDL.Types.SimpleController.PI)
"Multi zone VAV AHU economizer"
annotation (Placement(transformation(extent={{100,-40},{120,0}})));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,20 @@ model Controller_Mod_DamLim
Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Economizers.Controller
eco(
final minOADes=Buildings.Controls.OBC.ASHRAE.G36.Types.OutdoorAirSection.DedicatedDampersAirflow,

final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReliefFan,

final eneStd=Buildings.Controls.OBC.ASHRAE.G36.Types.EnergyStandard.ASHRAE90_1,

final ecoHigLimCon=Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedDryBulb,

final ashCliZon=Buildings.Controls.OBC.ASHRAE.G36.Types.ASHRAEClimateZone.Zone_1A)
"Multi zone VAV AHU economizer"
annotation (Placement(transformation(extent={{20,-20},{40,20}})));

Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Economizers.Controller
eco1(
final minOADes=Buildings.Controls.OBC.ASHRAE.G36.Types.OutdoorAirSection.DedicatedDampersPressure,

final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReturnFanMeasuredAir,

final eneStd=Buildings.Controls.OBC.ASHRAE.G36.Types.EnergyStandard.ASHRAE90_1,

final ecoHigLimCon=Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedDryBulb,

final ashCliZon=Buildings.Controls.OBC.ASHRAE.G36.Types.ASHRAEClimateZone.Zone_1B,

final venStd=Buildings.Controls.OBC.ASHRAE.G36.Types.VentilationStandard.ASHRAE62_1)
"Multi zone VAV AHU economizer"
annotation (Placement(transformation(extent={{100,-60},{120,-20}})));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ block PlantRequests "Output plant requests for multizone air handling unit"
final min=0,
final max=1)
if cooCoi == Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased
"Commanded ooling coil valve position"
"Commanded cooling coil valve position"
annotation (Placement(transformation(extent={{-240,80},{-200,120}}),
iconTransformation(extent={{-140,-50},{-100,-10}})));
Buildings.Controls.OBC.CDL.Interfaces.RealInput uHeaCoiSet(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ model FreezeProtection
Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.SetPoints.FreezeProtection
frePro(
final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReliefDamper,

final minOADes=Buildings.Controls.OBC.ASHRAE.G36.Types.OutdoorAirSection.DedicatedDampersAirflow,

final freSta=Buildings.Controls.OBC.ASHRAE.G36.Types.FreezeStat.No_freeze_stat)
"Freeze protection control"
annotation (Placement(transformation(extent={{80,0},{100,40}})));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ model FreezeProtection_Disable
frePro(
final have_frePro=false,
final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReliefDamper,

final minOADes=Buildings.Controls.OBC.ASHRAE.G36.Types.OutdoorAirSection.DedicatedDampersAirflow,

final freSta=Buildings.Controls.OBC.ASHRAE.G36.Types.FreezeStat.No_freeze_stat)
"Freeze protection control"
annotation (Placement(transformation(extent={{80,0},{100,40}})));
Expand Down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulating simulateModel("Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Validation.Controller_UnspecifiedClimate", method="Cvode", stopTime=3600, tolerance=1e-06, resultFile="MultizoneController");
gives warnings about unspecified climate that need to be corrected.

Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,11 @@ model Controller_UnspecifiedClimate

Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Controller conAHU(
final eneStd=Buildings.Controls.OBC.ASHRAE.G36.Types.EnergyStandard.ASHRAE90_1,

final venStd=Buildings.Controls.OBC.ASHRAE.G36.Types.VentilationStandard.ASHRAE62_1,

final ashCliZon=Buildings.Controls.OBC.ASHRAE.G36.Types.ASHRAEClimateZone.Not_Specified,

final minOADes=Buildings.Controls.OBC.ASHRAE.G36.Types.OutdoorAirSection.DedicatedDampersAirflow,

final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReliefDamper,

final ecoHigLimCon=Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedDryBulb,

final VUncDesOutAir_flow=0.05,
final VDesTotOutAir_flow=0.05) "Multizone VAV AHU controller"
annotation (Placement(transformation(extent={{100,-120},{180,40}})));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,13 @@ within Buildings.Controls.OBC.ASHRAE.G36.AHUs.SingleZone.VAV.Validation;
model Controller "Validation of the top-level controller"
Buildings.Controls.OBC.ASHRAE.G36.AHUs.SingleZone.VAV.Controller conVAV(
final eneStd=Buildings.Controls.OBC.ASHRAE.G36.Types.EnergyStandard.ASHRAE90_1,

final venStd=Buildings.Controls.OBC.ASHRAE.G36.Types.VentilationStandard.ASHRAE62_1,

final ecoHigLimCon=Buildings.Controls.OBC.ASHRAE.G36.Types.ControlEconomizer.FixedDryBulb,

final ashCliZon=Buildings.Controls.OBC.ASHRAE.G36.Types.ASHRAEClimateZone.Zone_1A,

final freSta=Buildings.Controls.OBC.ASHRAE.G36.Types.FreezeStat.No_freeze_stat,

final have_winSen=true,
final have_CO2Sen=false,
final buiPreCon=Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.ReliefDamper,

final VAreBreZon_flow=0.015,
final VPopBreZon_flow=0.0075,
final kHea=1,
Expand Down
Loading
Loading